Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114906
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable,
 allows any key&repeating keys)
Thread-Index: AQHXYe13gwPEOnQYu0+kS+xXdQPfpqsWWbeAgABMCZQ=
Date: Wed, 16 Jun 2021 13:57:47 +0000
Message-ID:
 <DM6PR07MB6618C365FD94F346A116C4E9F90F9@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <DM6PR07MB6618B452F34999B861638D84F9309@DM6PR07MB6618.namprd07.prod.outlook.com>,<CAF+90c8aHrm+R9+A-6bx2QnzmQHvqbgJcKzfnFtz6abHD1GnMA@mail.gmail.com>
In-Reply-To:
 <CAF+90c8aHrm+R9+A-6bx2QnzmQHvqbgJcKzfnFtz6abHD1GnMA@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [1Nt5/VNOaqTMiA5dh1hsvs0Q2GpEiKMxS8I80tJsxJBnpo95pfmMZWK67uDF49Am]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 447a4d48-cade-4753-4cc3-08d930ceb8ce
x-ms-traffictypediagnostic: BN8NAM04HT083:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 RiDpku1Rz287jvbuXm5uue8uzoLN76IhyEgCH9bwK0uXBMdslfOdtZNzwyCIFcKbA+Rb/vcZ2Wc8Ffwl+tzkVuWKC3uaezLWRjilp3IAgw/wsb6kLFU+DHrmEtJIgqtysOu8iWXMwFFTUCBL+jtgm+Lh9miqKpEMgtuT25tmcch6YuZP6Cuba+ZCki0b+mDVfutqTEPsIHbdbdwf7BOGcGA3fouMs1DBT/bSBi/VkV4JKQj6nsTQS6rwGIJ2NNyZWvs0Qgfql8RZe7vZtiHHrY1vDzlfgDX05JOVZyE94OYSRR92JqRZQV5Kq4OrNfd5qAnYzC/AwwiUeLtyszoHL8frMy1h1j2mCCv4QY8MCMUO3FRlGzDKa9WbgM8WKJOLV8jndZVLMZBSd2Z2sCUXFsrCXkt2uzpwS05YXntSLekg+QeJVOg75o74vXCBP/ovW23vTRxcozoChCgkE7mBUoSP8jRu+8h4v6fn4/KBKp8=
x-ms-exchange-antispam-messagedata:
 QWLPAOPvFU/WqX20U6eP6qs5epVvjW8Y+HHXiY6yGKLjLFoKO0BOOkIVSgYd2DeDONIwXcQqDwGAOLFn//zlCeiSOsXFRq8qIfiM7qyxiOs26ijRmSoedTPCYKZdiUZfnwE5850rARJpWfuCnbMJUR/gSDmbK8WpnPxm4KlPR1pEz50+NSA1orNwKmDY0IQCcCsQ6XBgt9qzGZY5+akHAA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM04FT027.eop-NAM04.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 447a4d48-cade-4753-4cc3-08d930ceb8ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2021 13:57:47.0330
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM04HT083
Subject: Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows
 any key&repeating keys)
From: tysonandre775@hotmail.com (tyson andre)

Hi Nikita,=0A=
=0A=
> I like the concept here. I think the naming choice is unfortunate, and ca=
using confusion for people.=0A=
> =0A=
> What you're really proposing here is a data structure: A sequence of key-=
value-pairs. That generally seems like a sensible thing to have, in that we=
 can implement it significantly more efficiently in core than you could do =
it in userland, especially when it comes to memory usage.=0A=
> =0A=
> The issue is that you're not really framing this as a data structure, but=
 as an iterable. I get that memoizing an iterable was the original motivati=
on here, but I think it causes confusion. If this were KeyValueSequence::fr=
omIterable($iterable), I think that the meaning and behavior would be perfe=
ctly clear -- of course it would eagerly collect the iterable, there is no =
other way it could reasonably work! I think Marco's concerns wouldn't come =
up either -- it's perfectly reasonable for a data structure to implement su=
pport for serialization and JSON encoding. Not so much for an iterator.=0A=
=0A=
It may be more positive, =0A=
but I don't think it'd pass with any name or by changing the constructor to=
 fromIterable.=0A=
Over half of the objections are to functionality, over half to unspecified =
reasons,=0A=
and other email discussion responses don't seem to indicate interest in hav=
ing the functionality, just on clarifying implementation or naming details=
=0A=
=0A=
I was trying to avoid proposing functionality similar to that already in ph=
p-ds or an improvement to spl=0A=
(especially with ongoing namespacing policy discussion),=0A=
but that seems to be a mistake - if it was chosen for inclusion in those mo=
dules then it'd be a very common use case=0A=
(e.g. https://www.php.net/manual/en/splqueue.construct, https://www.php.net=
/manual/en/class.ds-map.php, etc)=0A=
=0A=
Cheers,=0A=
Tyson=0A=