Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114888
MIME-Version: 1.0
References: <DM6PR07MB6618B452F34999B861638D84F9309@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB6618B452F34999B861638D84F9309@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Tue, 15 Jun 2021 16:18:19 +0200
Message-ID: <CADyq6sJNSpEBviGJ4ch0SzEX0PW4UmCjnaZzPYaeLYVr_zo39A@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000007b97805c4cea620"
Subject: Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows
 any key&repeating keys)
From: ocramius@gmail.com (Marco Pivetta)

--00000000000007b97805c4cea620
Content-Type: text/plain; charset="UTF-8"

Hey Tyson,
<http://ocramius.github.com/>


On Tue, Jun 15, 2021 at 4:01 PM tyson andre <tysonandre775@hotmail.com>
wrote:

> Hi internals,
>
> Voting has started on the ImmutableIterable RFC
> https://wiki.php.net/rfc/cachediterable
>
> Previous discussion can be found in https://externals.io/message/114834
>
> Recent changes:
> - The name was renamed to `ImmutableIterable` to indicate that it cannot
> be changed after being constructed.
>   It was brought up in previous discussions that the previous name of
> `CachedIterable` could easily be assumed to have functionality similar to
> on-demand iterators/iterables such as https://php.net/cachingiterator
>   (Additionally, immutability is rare among spl data structures)
> - `__set_state` was added
>

I see the RFC as valuable but:

 * `__serialize` and `__unserialize` are out of scope: this depends on the
contents of it, and there's no point in implementing them
 * `__set_state` should also not be implemented: `var_export()` like any
other object and it should be fine
 * `jsonSerialize` also depends on the contents, and shouldn't be exposed

All of this is not part of what should be in a reusable iterator.

Greets,

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--00000000000007b97805c4cea620--