Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114876
MIME-Version: 1.0
References: <CAGBsUrfnW-rEb6iy2_b5xumw_f-Ny-9vySqPFnfqtRiEaSXY+Q@mail.gmail.com>
 <CAPVMwwuP7Km6OX0EqmE3GkMzK3g=f_Sv6-M2e6wivMZJCnFPZw@mail.gmail.com>
 <C8A6B411-50CA-48DE-8046-651E4A576629@gmail.com> <CAPVMwwsk2f14vy4vGzD8Es55=bKJs6MLoQfUSOD8tRvS7K5kAw@mail.gmail.com>
 <CAGBsUrdPb9kyh569NmCY-Q87u=5bN9fgtVQyi65bK05NNq=XFg@mail.gmail.com>
In-Reply-To: <CAGBsUrdPb9kyh569NmCY-Q87u=5bN9fgtVQyi65bK05NNq=XFg@mail.gmail.com>
Date: Tue, 15 Jun 2021 10:17:41 +0300
Message-ID: <CAPVMwwt9KEkg7tTS=LodJMHw+nHP7vnkU5rc54xyOb8riby9XA@mail.gmail.com>
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: Claude Pache <claude.pache@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b0279305c4c8c593"
Subject: Re: [PHP-DEV] [VOTE] Deprecate autovivification on false
From: dmitrystogov@gmail.com (Dmitry Stogov)

--000000000000b0279305c4c8c593
Content-Type: text/plain; charset="UTF-8"

Hi Kamil,

PHP warnings are tricky, error handlers may cause side effects, throw
exceptions, etc.
Especially, for this deprecation you'll have to handle a new "slow" path
(in VM and JIT) that should return back to the main path.

Thanks. Dmitry.



On Fri, Jun 11, 2021 at 3:13 PM Kamil Tekiela <tekiela246@gmail.com> wrote:

> Hi Dmitry,
>
> Thanks for voicing your concerns.
> I have started writing implementation and it is definitely challenging for
> me, because I am not that experienced with PHP internals yet.
> https://github.com/php/php-src/pull/7131
>
> Almost every implementation requires some amount of work. I would like to
> ask you for more details on why you think this particular change is
> infeasible. Do you see any problems that the implementation of this
> deprecation message would cause? Would it be better to wait for PHP 9.0 and
> remove it without deprecation?
> As I see it, we already have an error for other scalar types. For false,
> we will just need to throw a deprecation notice in the same places. It
> doesn't require a major rewrite of PHP engine from what I can tell.
>
> Regards,
> Kamil
>

--000000000000b0279305c4c8c593--