Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114845
To: PHP Internals List <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] make Reflection*#setAccessible() no-op
Thread-Index: AQHXYHNxlAlWlobnu0CiArnpthCGZ6sSTh+h
Date: Sun, 13 Jun 2021 19:15:53 +0000
Message-ID:
 <DM6PR07MB6618A080A0E47A3F5E2531DCF9329@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <CADyq6sJX0BbiSBek9dAvgTtPMCbM-nObRBGtu27buqeMt8FWgA@mail.gmail.com>
In-Reply-To:
 <CADyq6sJX0BbiSBek9dAvgTtPMCbM-nObRBGtu27buqeMt8FWgA@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [VV+0RqNXTDmCQupenCcGp+ZrJ3lShZVTXBzRvZ36vBcoo5Da/jQkGtFxpRqsr2XE]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 370492b9-312b-405a-df50-08d92e9faa09
x-ms-traffictypediagnostic: DM6NAM10HT223:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 QFcBrO5Vlwjj6GvJWUWm7R9N1ZPztxi1za8yG/GxU0Kyrgp4M+TDRRan/OXFo+pF8mhRJXyqo2WRH6lS+Ek0L2g2FmA6100KAZ/ERlt7iIu7QqpC1g5j64liff2JY7zIFidbS+PAomDIFhiyQVC9zk5BJpvreiaRcBlcWSGG5ogBcIgJ3+nZIh0k//oqdcZ0+8C+aBz9lP6x/XBfomXavyzYQYdJX2f4AMDKQr/C2mxeT5dzGloQWd9eSM9TU7IEhjeWzb1jB41B70QIjBxlt8F4zKW1lqyh9jA+mxhlZEvmwotVQdKXQxHGGLnHTjBYLUB2uieWthZYXzyZnlQOyE48TSDPCKlPtzSqtVL/cMuzUUJvV53YUE2fmI+4NWPcmqf3NTSqHhE6GRvGtSx0OesrAs1eILwkxqf43rThIP+tWaafLmeVkVxEG1KzdJR10B9wqmvyJiGDwsw/ws15mA==
x-ms-exchange-antispam-messagedata:
 EbeOX4hX+GEQIXBYgENHLEb/mNBsSIwDkcwqL2G0mii+2wnMZKVQE3+jl74X0wrRR/MDB3RguB+fWYdVpwxLsWVBiP886ZuvW0g3oQwdto5EICmX1AG52ZadFPrtpFGsEiIIRJaLgXnnDBkK3WjpCHxWrYPiAoJ6PsucUPMDIJeoYpYfuZP9CcdcsQcko3r7OhODlItws9zrXnXBHyi+uQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT067.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 370492b9-312b-405a-df50-08d92e9faa09
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2021 19:15:53.6497
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT223
Subject: Re: [PHP-DEV] [RFC] make Reflection*#setAccessible() no-op
From: tysonandre775@hotmail.com (tyson andre)

Hi Marco Pivetta,=0A=
=0A=
> I'm posting here to introduce a new simplification, as well as=0A=
> quality-of-life-improving RFC:=0A=
> =0A=
> https://wiki.php.net/rfc/make-reflection-setaccessible-no-op=0A=
> =0A=
> The RFC is quite minimal, and proposes removing any runtime behavior from=
=0A=
> `ReflectionMethod#setAccessible()` and=0A=
> `ReflectionProperty#setAccessible()`, making `ReflectionMethod` and=0A=
> `ReflectionProperty` accessible by default.=0A=
> =0A=
> The rationale is:=0A=
> =0A=
> =A0* this API is probably coming from a copy-pasted java-ism (although I=
=0A=
> couldn't verify that, so I did not factor it into the RFC)=0A=
> =A0* removes the last bit of mutable state from `ReflectionProperty` and=
=0A=
> `ReflectionMethod`=0A=
> =A0* simplifies usage of the API=0A=
> =A0* if I'm up to no good, I don't need to actually solemnly swear that i=
 am=0A=
> up to no good (that's stuff for fantasy books)=0A=
> =0A=
> I don't really know what the deadline for 8.1 features is, but I assume=
=0A=
> it's coming up quite quickly, so friendly NikiC poked me to see if this=
=0A=
> long-standing patch of mine was still relevant.=0A=
> =0A=
> Should be short/sweet, but I'm looking forward to your feedback.=0A=
=0A=
The deadline for new features for 8.1 is July 20: https://wiki.php.net/todo=
/php81=0A=
(with some discretion from the release managers, e.g. for amendments to cha=
nges already made in 8.1)=0A=
=0A=
I think that isAccessible should be added if any applications actually did =
depend on ReflectionException=0A=
being thrown for correctness - they could throw their own exception if isAc=
cessible was false.=0A=
(e.g. for code meant to handle possibly undefined public typed properties b=
y checking for initialization=0A=
then getting the value)=0A=
=0A=
I can't actually remember needing this personally, though, since `$obj->{$m=
ethod}()` could be used.=0A=
I've only used this to access private and protected properties/methods.=0A=
=0A=
Regards,=0A=
Tyson=0A=