Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114789
Message-ID: <6C85F9DB-158F-4DEC-999C-F1D91406D029@newclarity.net>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_966A5C3F-60DD-4055-A2D2-4C5D98EE04D3"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.6\))
Date: Tue, 8 Jun 2021 18:58:11 -0400
In-Reply-To: <CAF+90c8RKxeAp1YycR1qi8oXJVbqe9rk17pW2G=C-fBA+R4ATg@mail.gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
To: Nikita Popov <nikita.ppv@gmail.com>
References: <CAF+90c-W_g9Mt9yMNzBWfMEmQP287a7A6S75RyZo2fvUO2uGXQ@mail.gmail.com>
 <83a9d0ab-60b8-4939-8be9-bdd6ddeb46c5@www.fastmail.com>
 <CAF+90c-=y=t2o0O7MbcWjqGUK8Z_imGuw5St3n_fGcARMWZvxg@mail.gmail.com>
 <9e921668-369c-41f2-a207-856cd098a3f1@www.fastmail.com>
 <CAF+90c8RKxeAp1YycR1qi8oXJVbqe9rk17pW2G=C-fBA+R4ATg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Readonly properties
From: mike@newclarity.net (Mike Schinkel)

--Apple-Mail=_966A5C3F-60DD-4055-A2D2-4C5D98EE04D3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On Jun 8, 2021, at 5:18 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:
>=20
> Well, I think we can get an approximation like this:
>=20
> =
https://beta.grep.app/search?q=3D%7B%20get%3B%20private%20set%3B%20%7D&fil=
ter[lang][0]=3DC%23 =
<https://beta.grep.app/search?q=3D{%20get;%20private%20set;%20}&filter[lan=
g][0]=3DC#>
> { get; private set; } 74,281 results
> https://beta.grep.app/search?q=3D%7B%20get%3B%20%7D&filter[lang][0]=3DC%=
23 <https://beta.grep.app/search?q=3D{%20get;%20}&filter[lang][0]=3DC#> =
{
> get; } 156,304 results
> https://beta.grep.app/search?q=3Dreadonly&filter[lang][0]=3DC%23 =
<https://beta.grep.app/search?q=3Dreadonly&filter[lang][0]=3DC#> =
readonly
> 409,585 results
>=20
> Note that the "{ get; }" part includes both readonly properties and
> get-only abstract properties, so that one is an overestimate. Using
> variants like \{\s+get;\s+private set;\s+\} doesn't change the results
> materially.
>=20
> Unless my methodology is completely borked, the ratio of readonly to
> asymmetric visibility seems to be something like 4:1 even as a =
conservative
> estimate.

When you two are speaking of "asymmetric visibility," are you speaking =
of this RFC[1], this one[2], one I am not mentioning, or one that does =
not exist yet?

If you are referring to [1] there is more to asymmetric visibility than =
what C# would call "auto-implemented properties[3]." =20

If we search for `get {` we find 266,859 occurrences and another 5765 =
for `{ set{`. I assume `readonly` would not address either of these?

=
https://beta.grep.app/search?current=3D2&q=3Dget%5Cs%2A%5C%7B&regexp=3Dtru=
e&filter[lang][0]=3DC%23 =
<https://beta.grep.app/search?current=3D2&q=3Dget%5Cs%2A%5C%7B&regexp=3Dtr=
ue&filter%5Blang%5D%5B0%5D=3DC%23>
=
https://beta.grep.app/search?q=3D%5C%7B%5Cs%2Aset%5Cs%2A%5C%7B&regexp=3Dtr=
ue&format=3De&filter[lang][0]=3DC%23 =
<https://beta.grep.app/search?q=3D%5C%7B%5Cs%2Aset%5Cs%2A%5C%7B&regexp=3Dt=
rue&format=3De&filter%5Blang%5D%5B0%5D=3DC%23>=20


-Mike
[1] https://wiki.php.net/rfc/property_accessors =
<https://wiki.php.net/rfc/property_accessors>
[2] https://wiki.php.net/rfc/property_write_visibility =
<https://wiki.php.net/rfc/property_write_visibility>=20
[3] =
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-a=
nd-structs/auto-implemented-properties =
<https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-=
and-structs/auto-implemented-properties>

P.S. You also over-counted `readonly` by 44k. If you go with =
case-sensitive for "readonly" you only get 365k. Seems they like using =
"ReadOnly" as part of symbol names.
https://beta.grep.app/search?q=3Dreadonly&case=3Dtrue&filter[lang][0]=3DC%=
23 =
<https://beta.grep.app/search?q=3Dreadonly&case=3Dtrue&filter%5Blang%5D%5B=
0%5D=3DC%23>

P.P.S. I'm not taking a position pro- or con- the readonly RFC, just =
wanting to clarify the stats used by others to evaluate.


--Apple-Mail=_966A5C3F-60DD-4055-A2D2-4C5D98EE04D3--