Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114767
To: internals@lists.php.net
References: <6D61A2FD-DC80-43A5-81C2-FB19F9CB5078@dafert.at>
 <CAF+90c_-qiTbzRigj+Tv=8CG-93DahbaxpcUSwtFSzjCOgJmcQ@mail.gmail.com>
Message-ID: <d2be409e-39cc-e5b7-e717-4da4309c4d00@gmail.com>
Date: Mon, 7 Jun 2021 14:03:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c_-qiTbzRigj+Tv=8CG-93DahbaxpcUSwtFSzjCOgJmcQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Policy for procedural style in new additions
From: dik.takken@gmail.com (Dik Takken)



On 07-06-2021 12:40, Nikita Popov wrote:
> I think that not adding new procedural mirror APIs is pretty
> uncontroversial at this point. I think one open question is regarding API
> additions to existing classes with a mirror API -- should we keep adding
> procedural functions in that case?

I guess maintaining consistency between the mirror APIs makes sense for
as long as we still have those mirror APIs.

> The more interesting question here is whether we want to deprecate existing
> APIs. From a quick look, these are the extensions that provide procedural
> mirror APIs:
> 
> date
> finfo
> intl
> mysqli
> oci8 (only partially)
> xmlwriter
> 
> I don't think I'd want to blanket deprecate all of these. I do see value in
> some of the procedural APIs (okay, only date really) or at least historical
> importance (mysqli is a migration target for mysql, which was only
> procedural). I think if we want to deprecate these, it should be on a
> case-by-case basis. For example, I see very little value in the procedural
> intl APIs.
> 
> One annoying factor here is that these mirror APIs were often added
> thoughtlessly and have design issues as a result. For example,
> xmlwriter_open_uri() makes sense, but XMLWriter::openUri() should clearly
> have been a static method, not an instance method. Similarly, mysqli_init()
> makes some sense, but mysqli::init() is entirely useless.

Deprecating the procedural APIs where it makes sense sounds like a great
step into the right direction. Historical oddities in the OO APIs could
be dealt with later.

Regards,
Dik Takken