Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114764
MIME-Version: 1.0
References: <8de4d96a-75d1-d732-020e-30bce0a5e03d@gmail.com>
In-Reply-To: <8de4d96a-75d1-d732-020e-30bce0a5e03d@gmail.com>
Date: Mon, 7 Jun 2021 12:52:46 +0200
Message-ID: <CAF+90c_GV2gE=7WFpAZ5nHPSs_22B6b0PGOqStnyGNmxj_=TDg@mail.gmail.com>
To: Timon de Groot <tdegroot96@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007400e505c42ad8cf"
Subject: Re: [PHP-DEV] [RFC][Draft] Add json_encode indent parameter
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000007400e505c42ad8cf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 3, 2021 at 6:11 PM Timon de Groot <tdegroot96@gmail.com> wrote:

> Hi internals,
>
> I'd like to present my RFC for adding the indent parameter to the
> json_encode function:
>    https://wiki.php.net/rfc/json_encode_indentation
>
> The `string|int $indent =3D 4` parameter adds the ability to specify the
> indentation for
> the JSON encoder. Amount of spaces can be specified by a number and a
> string can be
> specified to set a custom indentation like `\t` or whatever.
>
> As this is my first RFC (and contribution) for PHP, I'm all kind of new
> to the process, standards, etc.
> Please let me know if I could do something better.
>
> Looking forward to feedback/input on the RFC.
>

As has been brought up in
https://github.com/php/php-src/pull/7093#issuecomment-855170601, the string
version of the $indent parameter allows you to create invalid JSON,
something that json_encode() does not currently allow. I tend to agree that
it would make sense to validate that the indent only contains whitespace
characters, and not =F0=9F=9A=80.

Regards,
Nikita

--0000000000007400e505c42ad8cf--