Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114758
MIME-Version: 1.0
References: <CAA6+j4twA=gLkm3BQ6Hfv10e7sK7ci7jgxbZd0u=wvqJLM9hug@mail.gmail.com>
 <03294c9d-6cb3-35ec-913e-6adf8ac0b164@php.net>
In-Reply-To: <03294c9d-6cb3-35ec-913e-6adf8ac0b164@php.net>
Date: Mon, 7 Jun 2021 10:05:16 +0200
Message-ID: <CAF+90c-EMHo7F8ZN8nA1_aDU6v7SZq8BpHmVQJxTWjCJBArSPA@mail.gmail.com>
To: Remi Collet <remi@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000061447d05c42881fb"
Subject: Re: [PHP-DEV] Propagating AVIF support from libgd into PHP's bundled gd
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000061447d05c42881fb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 7, 2021 at 10:01 AM Remi Collet <remi@php.net> wrote:

> Le 04/06/2021 =C3=A0 16:36, Ben Morss via internals a =C3=A9crit :
>
> > ... I created a PR to propagate libgd's AVIF
> > support into PHP's bundled gd fork...
>
> Does it really make sense to keep maintaining this fork ?
>
> Having to maintain 2 (quite) different code and picking
> piece from one to other seems a waste of energy.
>
> I really think that we'll need to re-sync bundled gd
> with upstream and only keep it as an alternative for
> people without system gd (and perhaps even drop it later)
>

Once https://github.com/libgd/libgd/pull/692 lands, the goal would indeed
be to switch away from using a gd fork to bundling an unpatched upstream gd
(and maybe unbundling in the future). This is not entirely easy as the
codebases have diverged, but custom allocators are the current technical
blocker.

Regards,
Nikita

--00000000000061447d05c42881fb--