Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114750 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 90695 invoked from network); 6 Jun 2021 12:46:15 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 6 Jun 2021 12:46:15 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id AB688180502 for ; Sun, 6 Jun 2021 06:00:31 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 6 Jun 2021 06:00:31 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id m9so14344720ybo.5 for ; Sun, 06 Jun 2021 06:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WSffZhaIugRyrWtVzyxKDz+OGxZCy9uNfkSiHglQ3wg=; b=vbcIJtHZ2SXXrz2My2U2a5eJr2DvlYEZmtk8ycHllgb7cercKVrnX/XXPzX90dNGbZ PkPLxY3PSXK74tGILg1ns63FR62qWIZ1c/iP3fGU9AeUPGNUnzrg16i+BqymCpXuVyQE /nQeluNbEASZ1Iz0cVwxVQO0rclTVyF0Bn4BObVSoQu2ITgC4/jlOMFxCKUl1LjzABV8 C4hN78j+M/QtE2ii70AZ1IxO+SRdvWM3OrtA0sKkTS3MiNc1Qe9go/xmahOHtbBcoc75 haSfjdqpPMuPKHbVMWku2NovLic0UZuSWBIw517YhLr0Luvrq//yK+sK2TcrEmdaUKO0 hLTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WSffZhaIugRyrWtVzyxKDz+OGxZCy9uNfkSiHglQ3wg=; b=RlCee2LOnazbA04jiIBg0EfB3LJ/nZ7ffR5PBSvGWInAs6p9u1OcRTvycHrcDsOx9Q gqoNUgh2I2sBxsQG/tpfjIPhl9cnW7G1wLvaUNOleqvZD3QE8im3R2wZTOdVRHJ93tbw 7OLCZSi+vo+nCNacBVvUenFOTcDpO7StTsXZBEBscDnmoaCMLDU20RsJXWcK3TYgw8bc 4KoIMtvAse3+6Rq9G1OnWeGA0KFNaDwfRZhaI8S8NxCGi2aNeDFRFh2e2qY+xI9eAgaR 9uG0a1OKhTzB64RsV4W6tVrloHpUEzBe4MvtvuvtRFuOH+g4L69pDrTfjGbBPJLw/DwH XBQA== X-Gm-Message-State: AOAM533dVj42w28HU1c5ppLB2c4ZKhfFjTbXdd6ZU17kZ7q/OrLxq+bI QB2DSSMPvStFp3LFxFNB9zKI0qcYh88n7uVV/gglVQ== X-Google-Smtp-Source: ABdhPJwwcEwSRvekizmpUUtYzbGd1lRgKwzG5JjFuGPnSIGeDU0/6oKeYjcmKxceiWzAfwzRXEMk0o5HmK6S8hMTHek= X-Received: by 2002:a25:1b0b:: with SMTP id b11mr17623314ybb.302.1622984425799; Sun, 06 Jun 2021 06:00:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Reply-To: Ben Morss Date: Sun, 6 Jun 2021 09:00:08 -0400 Message-ID: To: Ayesh Karunaratne Cc: Kalle Sommer Nielsen , PHP internals Content-Type: multipart/alternative; boundary="0000000000002d783c05c41882f0" Subject: Re: [PHP-DEV] Propagating AVIF support from libgd into PHP's bundled gd From: internals@lists.php.net ("Ben Morss via internals") --0000000000002d783c05c41882f0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you for these comments! Perhaps it would make sense to, at some point, create a followup proposal to namespace the entire gd extension - so that all gd functions would be in the namespace? I'd leave it to others to determine whether this would be desirable, or whether it wouldn't be worth making developers update existing code. On Sun, Jun 6, 2021 at 6:08 AM Ayesh Karunaratne wrote: > > > > Den s=C3=B8n. 6. jun. 2021 kl. 00.09 skrev Ayesh Karunaratne >: > > > > > > Hi Ben, > > > Thank you for opening this PR and the discussion. With the wide > > > availability of AVIF/AV1 support in browsers, I think this will fit > > > nicely. > > > > > > We have the Namespaces in Bundled Extensions RFC > > > (https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, s= o > > > perhaps, the new functions are probably better in the `Gd` namespace? > > > This would mean the new functions would be `\Gd\imagecreatefromavif` > > > and `\Gd\imageavif`. They are inconsistent with the existing function= s > > > of course, but I thought to mention it because it's a recent proposal > > > and I don't think we added new functions after that RFC. Some example= s > > > are recently renamed PHP classes in IMAP, Pgsql, LDAP, and FTP > > > extensions to follow this new proposal. > > > > I don't think it makes much sense to do that for a single function, > > because it makes the API cluttered, as why would I call > > `\Gd\imagecreatefromavif` when everything else is in the global > > namespace? That is a poor design, while I understand the intentions > > behind it is good. > > > > I think this needs to be well thoughtout in a topic on its own rather > > than off topicing it here, so I will leave it at that. > > > > > > Overall, +1 for adding this > > -- > > regards, > > > > Kalle Sommer Nielsen > > kalle@php.net > > I also think going with `imagecreatefromavif`/`imageavif` is good for > consistency. I brought that RFC up because it was recent and this is > the first new function we are adding. > > Thank you. > --0000000000002d783c05c41882f0--