Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114749 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 76704 invoked from network); 6 Jun 2021 09:54:10 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 6 Jun 2021 09:54:10 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 93EAE1804D8 for ; Sun, 6 Jun 2021 03:08:22 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from forward103o.mail.yandex.net (forward103o.mail.yandex.net [37.140.190.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 6 Jun 2021 03:08:21 -0700 (PDT) Received: from myt5-36442628f0be.qloud-c.yandex.net (myt5-36442628f0be.qloud-c.yandex.net [IPv6:2a02:6b8:c12:1c0c:0:640:3644:2628]) by forward103o.mail.yandex.net (Yandex) with ESMTP id 1E6535F80A7C for ; Sun, 6 Jun 2021 13:08:19 +0300 (MSK) Received: from myt6-016ca1315a73.qloud-c.yandex.net (myt6-016ca1315a73.qloud-c.yandex.net [2a02:6b8:c12:4e0e:0:640:16c:a131]) by myt5-36442628f0be.qloud-c.yandex.net (mxback/Yandex) with ESMTP id rH0m4QIqxO-8IKajHp2; Sun, 06 Jun 2021 13:08:19 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=php.watch; s=mail; t=1622974099; bh=A7hCKGPfGaqKRua4W4bFVzSGFuWctq4TpCoe35qi1IQ=; h=To:Subject:From:In-Reply-To:Cc:Message-ID:Date:References; b=uJMNblMzrs16ScYs8vzwhOyQqdyPQ6VIztsEp3QPrE6zQPyeCa9sVFrtZInAaMPvW 1rqB7KodB9nPalx+CWW8Qcw+xpWYLV8ugx2hbs6NJLk6/G90kDFXFqWDimKTIkvuNB iIn2Fji6giAqQ5HDOnK285T27y+1PfpE0UdHcTfc= Authentication-Results: myt5-36442628f0be.qloud-c.yandex.net; dkim=pass header.i=@php.watch Received: by myt6-016ca1315a73.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id hwr6QhwSPI-8HL0OBvn; Sun, 06 Jun 2021 13:08:17 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Received: by mail-ot1-f48.google.com with SMTP id v27-20020a056830091bb02903cd67d40070so10664170ott.1 for ; Sun, 06 Jun 2021 03:08:17 -0700 (PDT) X-Gm-Message-State: AOAM530JBppI9lKTsWDrlxNFzDGzczKN9A4bSvcD3b7wUahpgrtmRnZ6 v14crT1Xe+fhyMNkyJ9blYRpfWzEZ2waemXSOKw= X-Google-Smtp-Source: ABdhPJzgJuDQTbG74db3aPYd+GO+yu0c3C8gCd0L8iknw9OUKmYzjJ1uXnVpIuHtiV9QbWgUMDrD74RF/+9rJ74hbKk= X-Received: by 2002:a9d:34a:: with SMTP id 68mr3058852otv.190.1622974096409; Sun, 06 Jun 2021 03:08:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Sun, 6 Jun 2021 15:37:49 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Kalle Sommer Nielsen Cc: Ben Morss , PHP internals Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Propagating AVIF support from libgd into PHP's bundled gd From: ayesh@php.watch (Ayesh Karunaratne) > > Den s=C3=B8n. 6. jun. 2021 kl. 00.09 skrev Ayesh Karunaratne : > > > > Hi Ben, > > Thank you for opening this PR and the discussion. With the wide > > availability of AVIF/AV1 support in browsers, I think this will fit > > nicely. > > > > We have the Namespaces in Bundled Extensions RFC > > (https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, so > > perhaps, the new functions are probably better in the `Gd` namespace? > > This would mean the new functions would be `\Gd\imagecreatefromavif` > > and `\Gd\imageavif`. They are inconsistent with the existing functions > > of course, but I thought to mention it because it's a recent proposal > > and I don't think we added new functions after that RFC. Some examples > > are recently renamed PHP classes in IMAP, Pgsql, LDAP, and FTP > > extensions to follow this new proposal. > > I don't think it makes much sense to do that for a single function, > because it makes the API cluttered, as why would I call > `\Gd\imagecreatefromavif` when everything else is in the global > namespace? That is a poor design, while I understand the intentions > behind it is good. > > I think this needs to be well thoughtout in a topic on its own rather > than off topicing it here, so I will leave it at that. > > > Overall, +1 for adding this > -- > regards, > > Kalle Sommer Nielsen > kalle@php.net I also think going with `imagecreatefromavif`/`imageavif` is good for consistency. I brought that RFC up because it was recent and this is the first new function we are adding. Thank you.