Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114748
MIME-Version: 1.0
References: <CAA6+j4twA=gLkm3BQ6Hfv10e7sK7ci7jgxbZd0u=wvqJLM9hug@mail.gmail.com>
 <CANLbj-oohd1mjrVnq=9ouEakZfD8O5wjtAi88BybrRSE0UdAAg@mail.gmail.com>
In-Reply-To: <CANLbj-oohd1mjrVnq=9ouEakZfD8O5wjtAi88BybrRSE0UdAAg@mail.gmail.com>
Date: Sun, 6 Jun 2021 04:41:17 +0300
Message-ID: <CAJW__o2JSH4SW=oHTuD89+MRR=rBydK2UA-J0ecDDriCm+ja2w@mail.gmail.com>
To: Ayesh Karunaratne <ayesh@php.watch>
Cc: Ben Morss <morss@google.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Propagating AVIF support from libgd into PHP's bundled gd
From: kalle@php.net (Kalle Sommer Nielsen)

Den s=C3=B8n. 6. jun. 2021 kl. 00.09 skrev Ayesh Karunaratne <ayesh@php.wat=
ch>:
>
> Hi Ben,
> Thank you for opening this PR and the discussion. With the wide
> availability of AVIF/AV1 support in browsers, I think this will fit
> nicely.
>
> We have the Namespaces in Bundled Extensions RFC
> (https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, so
> perhaps, the new functions are probably better in the `Gd` namespace?
> This would mean the new functions would be `\Gd\imagecreatefromavif`
> and `\Gd\imageavif`. They are inconsistent with the existing functions
> of course, but I thought to mention it because it's a recent proposal
> and I don't think we added new functions after that RFC. Some examples
> are recently renamed PHP classes in IMAP, Pgsql, LDAP, and FTP
> extensions to follow this new proposal.

I don't think it makes much sense to do that for a single function,
because it makes the API cluttered, as why would I call
`\Gd\imagecreatefromavif` when everything else is in the global
namespace? That is a poor design, while I understand the intentions
behind it is good.

I think this needs to be well thoughtout in a topic on its own rather
than off topicing it here, so I will leave it at that.


Overall, +1 for adding this
--=20
regards,

Kalle Sommer Nielsen
kalle@php.net