Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114725
To: internals@lists.php.net
References: <e1942470-dc68-0e20-3ccd-da420da74cb9@gmail.com>
 <CA+p1FabKpJq=PKSag1-cJQfQ5VTms2Mu=mshD5Tu52Km1-CErQ@mail.gmail.com>
 <06f92428-a426-0afa-72ab-053e224a87ce@seld.be>
 <4c8f7ea1-6112-8046-846c-b701ab707752@gmail.com>
 <CAFPFaMJR2wd1vPRruoAjK+XuO67nqcB5CgnkgSbMfvFAnmx1Vw@mail.gmail.com>
 <d1da59fb-08c1-4d10-02a6-5891d9ea1933@gmail.com>
 <CANLbj-r5X_=y5btu1wN9AFAjswODQmyO5Yswno=KcbjXDocjTQ@mail.gmail.com>
 <1008623e-faed-aa39-3b58-48d37d306e5d@gmail.com>
Message-ID: <5b1ee897-d01a-9636-c3c0-c435f7708f66@seld.be>
Date: Fri, 4 Jun 2021 08:24:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <1008623e-faed-aa39-3b58-48d37d306e5d@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [PHP-DEV] json_encode indent parameter
From: j.boggiano@seld.be (Jordi Boggiano)

On 03/06/2021 18:03, Timon de Groot wrote:
> On 3-6-2021 17:53, Ayesh Karunaratne wrote:
>> Hi Timon,
>> Thank you for this RFC. I think the `string|int $indent` approach is 
>> great 🚀!
>>
>> Reading the PR, it looks like `$indent=0` is essentially turning off
>> pretty-print, which I think is intuitive.
> Basically, yes. With `$indent=0`, no indentation will take place but 
> new lines will still be added.
>> Do you plan to add any sort of validation on negative integers?
>> Perhaps throw a `\ValueError` exception on $indent < 0?
>
> Good question. Personally I'd prefer clamping $indent to 0 when it 
> reaches below 0. But I'd like
> to hear about what other particpants think about such behavior.
>
IMO the JS spec is quite reasonable there, and I would say copying it 
1:1 would be fine:

     If this is a Number, it indicates the number of space characters to 
use as white space; this number is capped at 10 (if it is greater, the 
value is just 10). Values less than 1 indicate that no space should be used.

     If this is a String, the string (or the first 10 characters of the 
string, if it's longer than that) is used as white space. If this 
parameter is not provided (or is null), no white space is used.

Best,
Jordi

-- 
Jordi Boggiano
@seldaek - https://seld.be