Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114716
To: Ayesh Karunaratne <ayesh@php.watch>
Cc: PHP internals <internals@lists.php.net>
References: <e1942470-dc68-0e20-3ccd-da420da74cb9@gmail.com>
 <CA+p1FabKpJq=PKSag1-cJQfQ5VTms2Mu=mshD5Tu52Km1-CErQ@mail.gmail.com>
 <06f92428-a426-0afa-72ab-053e224a87ce@seld.be>
 <4c8f7ea1-6112-8046-846c-b701ab707752@gmail.com>
 <CAFPFaMJR2wd1vPRruoAjK+XuO67nqcB5CgnkgSbMfvFAnmx1Vw@mail.gmail.com>
 <d1da59fb-08c1-4d10-02a6-5891d9ea1933@gmail.com>
 <CANLbj-r5X_=y5btu1wN9AFAjswODQmyO5Yswno=KcbjXDocjTQ@mail.gmail.com>
Message-ID: <1008623e-faed-aa39-3b58-48d37d306e5d@gmail.com>
Date: Thu, 3 Jun 2021 18:03:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CANLbj-r5X_=y5btu1wN9AFAjswODQmyO5Yswno=KcbjXDocjTQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: nl
Subject: Re: [PHP-DEV] json_encode indent parameter
From: tdegroot96@gmail.com (Timon de Groot)

On 3-6-2021 17:53, Ayesh Karunaratne wrote:
> Hi Timon,
> Thank you for this RFC. I think the `string|int $indent` approach is great 🚀!
>
> Reading the PR, it looks like `$indent=0` is essentially turning off
> pretty-print, which I think is intuitive.
Basically, yes. With `$indent=0`, no indentation will take place but new 
lines will still be added.
> Do you plan to add any sort of validation on negative integers?
> Perhaps throw a `\ValueError` exception on $indent < 0?

Good question. Personally I'd prefer clamping $indent to 0 when it 
reaches below 0. But I'd like
to hear about what other particpants think about such behavior.

Thank you for your feedback :).

--

Kind regards,

Timon de Groot