Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114711
MIME-Version: 1.0
References: <e1942470-dc68-0e20-3ccd-da420da74cb9@gmail.com>
 <CA+p1FabKpJq=PKSag1-cJQfQ5VTms2Mu=mshD5Tu52Km1-CErQ@mail.gmail.com>
 <06f92428-a426-0afa-72ab-053e224a87ce@seld.be> <4c8f7ea1-6112-8046-846c-b701ab707752@gmail.com>
In-Reply-To: <4c8f7ea1-6112-8046-846c-b701ab707752@gmail.com>
Date: Thu, 3 Jun 2021 15:15:16 +0100
Message-ID: <CAFPFaMJR2wd1vPRruoAjK+XuO67nqcB5CgnkgSbMfvFAnmx1Vw@mail.gmail.com>
To: Timon de Groot <tdegroot96@gmail.com>
Cc: Jordi Boggiano <j.boggiano@seld.be>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f6468d05c3dd3439"
Subject: Re: [PHP-DEV] json_encode indent parameter
From: george.banyard@gmail.com ("G. P. B.")

--000000000000f6468d05c3dd3439
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 3 Jun 2021 at 11:49, Timon de Groot <tdegroot96@gmail.com> wrote:

> On 3-6-2021 10:00, Jordi Boggiano wrote:
> > I agree, but I'd make it accept a string|int much like JSON.stringify
> > does, because that way you let people pass in tabs too, or "=F0=9F=9A=
=80" if
> > that's how you want your JSON indented..
>
> I like the idea of accepting string|int.
>
> Accepting string|int means a zval needs to be used, with the possibility
> to pass any type of variable (please correct me if I'm wrong here).
> Should the function throw an error when it receives anything other than
> a string|int?
>

That's incorrect, as of PHP 8.0 Fast ZPP has a way to deal with the most
common union types, including int|string.

Best regards,

George P. Banyard

--000000000000f6468d05c3dd3439--