Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114707
To: Mike Schinkel <mike@newclarity.net>
Cc: internals@lists.php.net
References: <CAC47A8B-EFA1-41C1-908B-065D399D396F@newclarity.net>
 <d1cd0e33-45c8-8067-9861-8853d329d0c0@seld.be>
 <761D99C1-4728-4EE8-95F8-44A240AE1473@newclarity.net>
Message-ID: <c478685b-83c3-79f0-1c27-ce1d4f58ecfb@seld.be>
Date: Thu, 3 Jun 2021 13:32:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <761D99C1-4728-4EE8-95F8-44A240AE1473@newclarity.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [PHP-DEV] Regarding array_shift()/array_unshift()
From: j.boggiano@seld.be (Jordi Boggiano)

Hah, I sure did not expect my answer to trigger these 5 complex RFCs 
worth of work ;)


On 03/06/2021 00:59, Mike Schinkel wrote:

>
> 4.) Given Nikita's comments on the O(<n>) performance of array_shift() have you considered instead simulating a FIFO queue using an array as a stack?  Any reason that would not work for your needs?

I think your analysis is overall on point. There are probably better 
data structures that could lead to me not needing array_shift in most 
places I use it. However arrays are quite the tool in PHP, and lazy as 
it may be they usually do the job well enough and the perf overhead of 
reindexing (which tbh I was not aware of until this thread) seems 
unnoticeable in most case (a quick test shows 1ms to shift a 300K item 
array on my loaded laptop, which is really quite acceptable).


> So in summary the tangential topics I addressed were:
>
> 1.) PHP potentially supporting multiple return values, and
> 2.) Renewed focus on SPL data structures.
>
> Again, if anyone is interested in these tangential topics and wants to discuss further, please create a new thread and quote my applicable comments from this email.
To your other points: Multiple return values and SPL with better 
docs/naming/usability would absolutely be great to have from my userland 
perspective.

Best,
Jordi

-- 
Jordi Boggiano
@seldaek - https://seld.be