Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114706
Return-Path: <tdegroot96@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 51361 invoked from network); 3 Jun 2021 10:35:38 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 3 Jun 2021 10:35:38 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id A5E701804DB
	for <internals@lists.php.net>; Thu,  3 Jun 2021 03:49:07 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,
	FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2
X-Spam-Virus: No
X-Envelope-From: <tdegroot96@gmail.com>
Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Thu,  3 Jun 2021 03:49:07 -0700 (PDT)
Received: by mail-wm1-f48.google.com with SMTP id t16-20020a05600c1990b02901a0d45ff03aso2050558wmq.2
        for <internals@lists.php.net>; Thu, 03 Jun 2021 03:49:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=subject:to:references:from:message-id:date:user-agent:mime-version
         :in-reply-to:content-transfer-encoding:content-language;
        bh=/ydD4degdHy4qLN7UWfZAzvErcuszPSQS0zBomLoge4=;
        b=Sl4n5mTctYjji9lwOeM80FE4dBcxxjk2cyRYJ3znLmKFRGxf3ISYCGQs9NO4kIEpBb
         D6p4qSVFI6aVUIssqrjjWzDEP2P5xLlmfEIs9DxepHIagRQLNxRQ6Qi9zsPStML5ZNV4
         vpJ1wGliudP9W9xHGsVbFfUKnOXuMoqDCFomu0waOAG2iEik8nuTs6w5nDAVjWjsGbTp
         OcczqwrA5K0O9laywOTgWmomtBv9RHshmZDek7OqJ7zwPEcyafvwyThioy0PGOdNsPFl
         VnKC21mkr0JA1byJWL13Cehih6qnJ95QkPYW74eXduayittOGxqqxfUi1YPY3vwLKVC7
         DzpA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=/ydD4degdHy4qLN7UWfZAzvErcuszPSQS0zBomLoge4=;
        b=FN2rDZhOvU8iS6FmulR06kwJWT7UbPLKZzZDG2V7lKUzOIypcFBNkMsxRGQSvZL40u
         HNC7C9RqiJY4kEcggsVdMSSaxy03clhW/2epvqOtMAhecjQGi7iPPLfG4WfjzwWhEtvx
         JhrjxMHHQ1kTQkYzIap/t07TR1/XXo1s44hpFKhiGZduqHndLWcH5wUo4Lfxa9HM/VkQ
         X81Ds/70uZQweOPQ3JTQs7YR/6H07iB+vN/TrrRnuJZBMZZuEadESmMnLcDx91pUdm6N
         JnhuSV4biWEwqYCniHARIvCTySb0wgUGX/sqQ1h/pfhahEHJEdea1LUeBduBmPALY6ct
         yRow==
X-Gm-Message-State: AOAM530GK52vzflpHRYsnA3l0BQyCOuHkXvgvmc33cIjLBe2JbMzVPXv
	wWXqjB64nPq20W23CeS/aOqeaZSKC1caZZMH
X-Google-Smtp-Source: ABdhPJwNBXbF838a6nGPhNDEmwsF0IpuiJ2Oc6tntvYcctEEswwQ/0WELVKB6InP14RulziOjLp6Wg==
X-Received: by 2002:a1c:b783:: with SMTP id h125mr9625989wmf.182.1622717345201;
        Thu, 03 Jun 2021 03:49:05 -0700 (PDT)
Received: from [192.168.2.117] (86-84-29-36.fixed.kpn.net. [86.84.29.36])
        by smtp.gmail.com with ESMTPSA id o17sm2778476wrp.47.2021.06.03.03.49.04
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 03 Jun 2021 03:49:04 -0700 (PDT)
To: Jordi Boggiano <j.boggiano@seld.be>, internals@lists.php.net
References: <e1942470-dc68-0e20-3ccd-da420da74cb9@gmail.com>
 <CA+p1FabKpJq=PKSag1-cJQfQ5VTms2Mu=mshD5Tu52Km1-CErQ@mail.gmail.com>
 <06f92428-a426-0afa-72ab-053e224a87ce@seld.be>
Message-ID: <4c8f7ea1-6112-8046-846c-b701ab707752@gmail.com>
Date: Thu, 3 Jun 2021 12:49:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <06f92428-a426-0afa-72ab-053e224a87ce@seld.be>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: nl
Subject: Re: [PHP-DEV] json_encode indent parameter
From: tdegroot96@gmail.com (Timon de Groot)

On 3-6-2021 10:00, Jordi Boggiano wrote:
> I agree, but I'd make it accept a string|int much like JSON.stringify 
> does, because that way you let people pass in tabs too, or "🚀" if 
> that's how you want your JSON indented..

I like the idea of accepting string|int.

Accepting string|int means a zval needs to be used, with the possibility 
to pass any type of variable (please correct me if I'm wrong here).
Should the function throw an error when it receives anything other than 
a string|int?

--

Kind regards,

Timon de Groot