Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114693
MIME-Version: 1.0
References: <CABTDVhC_h-+pG54KuJu6g-CFQPqaMJ=PUF02FMjjENvP1dpfzg@mail.gmail.com>
 <a9a2565f-fb9e-c4d4-d898-0ae9f5e0efdb@seld.be>
In-Reply-To: <a9a2565f-fb9e-c4d4-d898-0ae9f5e0efdb@seld.be>
Date: Wed, 2 Jun 2021 20:55:48 +0900
Message-ID: <CABTDVhBXGKhY+EeXKd1S=qav4hrNVmz1m-gHv5kAvrQEbjVehA@mail.gmail.com>
To: Jordi Boggiano <j.boggiano@seld.be>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005ec2f305c3c72421"
Subject: Re: [PHP-DEV] [RFC] Under Discussion: Add Random class and
 RandomNumberGenerator interface
From: zeriyoshi@gmail.com (Go Kudo)

--0000000000005ec2f305c3c72421
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

It was good! I was finally able to put some things together.
Thank you for participating in the discussion.

> typo

Thanks, I fixed it!

> InvalidArgumentException

I think InvalidArgumentException is included in the ext/spl extension, but
is it safe to use it from ext/standard?
If it is available, then it is certainly more appropriate.

Regards,
Go Kudo

2021=E5=B9=B46=E6=9C=882=E6=97=A5(=E6=B0=B4) 17:51 Jordi Boggiano <j.boggia=
no@seld.be>:

> On 01/06/2021 16:28, Go Kudo wrote:
> > Hello internals.
> > Thanks for continuing to participate in the discussion.
> >
> > I've sorted out the proposal, and finished writing and implementing the
> RFC.
> > (Funny, I know.) I think it's time to start a discussion.
> >
> > https://wiki.php.net/rfc/rng_extension
> > https://github.com/php/php-src/pull/7079
> >
> > The main changes since last time are as follows:
> >
> > - The ugly RANDOM_USER has been removed.
> > - RandomNumberGenerator interface has been added for user-defined RNGs.
> > - Random class is now final.
> > - Random class now accepts a RandomNumberGenerator interface other than
> > string as the first argument to the constructor.
> > - INI directive has been removed. In 32-bit environments, the result is
> > always truncated.
>
> Overall this looks much better! From a PHP userland perspective I can't
> see any huge problem at first glance.
>
> Just a few notes:
>
> - "Random class can be serialized or cloned if the algorithm supports
> it." It isn't clear to me how that support is defined in a userland
> implementation? Simply by implementing __serialize/__unserialize?
> - The __unserialize docblock has two typos (Useri*i*alize and *in*
> instead of if)
> - If an object is passed to `new Random($obj)`, probably it should throw
> an InvalidArgumentException if a seed is also passed in, as I assume in
> that case it would be otherwise be ignored.
>
> Best,
> Jordi
>
> --
> Jordi Boggiano
> @seldaek - https://seld.be
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--0000000000005ec2f305c3c72421--