Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114692
To: internals@lists.php.net
References: <CABTDVhC_h-+pG54KuJu6g-CFQPqaMJ=PUF02FMjjENvP1dpfzg@mail.gmail.com>
Message-ID: <a9a2565f-fb9e-c4d4-d898-0ae9f5e0efdb@seld.be>
Date: Wed, 2 Jun 2021 10:51:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <CABTDVhC_h-+pG54KuJu6g-CFQPqaMJ=PUF02FMjjENvP1dpfzg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [PHP-DEV] [RFC] Under Discussion: Add Random class and
 RandomNumberGenerator interface
From: j.boggiano@seld.be (Jordi Boggiano)

On 01/06/2021 16:28, Go Kudo wrote:
> Hello internals.
> Thanks for continuing to participate in the discussion.
>
> I've sorted out the proposal, and finished writing and implementing the RFC.
> (Funny, I know.) I think it's time to start a discussion.
>
> https://wiki.php.net/rfc/rng_extension
> https://github.com/php/php-src/pull/7079
>
> The main changes since last time are as follows:
>
> - The ugly RANDOM_USER has been removed.
> - RandomNumberGenerator interface has been added for user-defined RNGs.
> - Random class is now final.
> - Random class now accepts a RandomNumberGenerator interface other than
> string as the first argument to the constructor.
> - INI directive has been removed. In 32-bit environments, the result is
> always truncated.

Overall this looks much better! From a PHP userland perspective I can't 
see any huge problem at first glance.

Just a few notes:

- "Random class can be serialized or cloned if the algorithm supports 
it." It isn't clear to me how that support is defined in a userland 
implementation? Simply by implementing __serialize/__unserialize?
- The __unserialize docblock has two typos (Useri*i*alize and *in* 
instead of if)
- If an object is passed to `new Random($obj)`, probably it should throw 
an InvalidArgumentException if a seed is also passed in, as I assume in 
that case it would be otherwise be ignored.

Best,
Jordi

-- 
Jordi Boggiano
@seldaek - https://seld.be