Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114691
To: internals@lists.php.net
References: <CAC47A8B-EFA1-41C1-908B-065D399D396F@newclarity.net>
Message-ID: <d1cd0e33-45c8-8067-9861-8853d329d0c0@seld.be>
Date: Wed, 2 Jun 2021 10:25:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <CAC47A8B-EFA1-41C1-908B-065D399D396F@newclarity.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [PHP-DEV] Regarding array_shift()/array_unshift()
From: j.boggiano@seld.be (Jordi Boggiano)

On 02/06/2021 00:34, Mike Schinkel wrote:
> But from all this I do agree with you that just returning an array 
> would likely be acceptable.
> -----
>
> This would not be a great solution for really large arrays, but then we can't eliminate the need for a developer to have a reasonable level of knowledge, right?  So:
>
> $unshifted = $array->unshift($new_element);
> $shifted = $array->shift();
>
> But, we could also possibly use better names for these:
>
> $right_shifted = $array->shift_right(...$new_element(s));
> $left_shifted = $array->shift_left([element_count]);

IMO for unshift() it'd be fine to return a new array, but when 
processing a list of things in a FIFO pattern I often used array_shift() 
to get the first "job" out of the array. If $array->shift() returns a 
new array then how do I access the first item?

I mean sure one can call reset first to get it, but I find this isn't 
great ergonomics compared to the existing.

Best,
Jordi

-- 
Jordi Boggiano
@seldaek - https://seld.be