Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114643
To: internals@lists.php.net
References: <CAOwTYAtc_xD6n=efmamkAy4ro4KqPKxq18-zXsNriY0280FY2g@mail.gmail.com>
 <319c4288-5934-b218-d6eb-0b787a2cdef1@gmx.net>
Message-ID: <aac7b654-cbf2-5d02-6ff6-16e5e7ad8793@gmail.com>
Date: Thu, 27 May 2021 15:43:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <319c4288-5934-b218-d6eb-0b787a2cdef1@gmx.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] Consensus Gathering: is_initialized
From: rowan.collins@gmail.com (Rowan Tommins)

On 27/05/2021 14:55, Andreas Leathley wrote:
>
> When using isset on a non-nullable property a
> static analyzer would rightfully complain that the property is not
> nullable


Precisely, so don't mark a property as non-nullable and then leave it unset.


> isset in this case is abused to check for uninitialized, hiding the
> actual intent


On the contrary, the uninitialized state is what is being abused. If you 
want to make the intent clear, use a clear flag of "needs lazy-loading", 
or whatever you're actually using this magic "not null but not really 
anything else either" state for.


Regards,

-- 
Rowan Tommins
[IMSoP]