Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114621
MIME-Version: 1.0
References: <CAOwTYAtc_xD6n=efmamkAy4ro4KqPKxq18-zXsNriY0280FY2g@mail.gmail.com>
 <80fb5a8e-d770-49fd-45d5-ea6f4b004513@gmail.com> <2874cf7c-e55d-4100-bb01-af11a5ab6e87@www.fastmail.com>
In-Reply-To: <2874cf7c-e55d-4100-bb01-af11a5ab6e87@www.fastmail.com>
Date: Wed, 26 May 2021 18:20:11 +0200
Message-ID: <CAC5V6ghyHFrrvgL_rXQKAKt1KMAVCRbGxhQb4Ouqojn474jLMQ@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f8195305c33e044b"
Subject: Re: [PHP-DEV] Consensus Gathering: is_initialized
From: guilliam.xavier@gmail.com (Guilliam Xavier)

--000000000000f8195305c33e044b
Content-Type: text/plain; charset="UTF-8"

On Wed, May 26, 2021 at 4:09 PM Larry Garfield <larry@garfieldtech.com>
wrote:

> On Wed, May 26, 2021, at 8:24 AM, Rowan Tommins wrote:
> > On 26/05/2021 11:13, Joe Watkins wrote:
> > > Hi internals,
> > >
> > > In response to: https://bugs.php.net/bug.php?id=78480
> > >
> > > I implemented: https://github.com/php/php-src/pull/7029
> >
> >
> > My general feeling remains that the "uninitialized" state is an awkward
> > hack that we should be working to eliminate with better constructor
> > semantics. A variable that remains uninitialised after the constructor
> > almost always indicates a bug in the constructor, not a state that the
> > rest of the application should care about.
>
> I am inclined to agree here.  What I don't know about is the cases noted
> in the bug, such as GraphQL or other serialization cases where "null" and
> "absent" are not quite the same thing.  That is probably sufficiently
> edge-case to not deal with directly, especially when the more verbose
> alternative still exists, but that's the only reason I'd even consider
> making uninitialized something other than "your constructor is bad and you
> should feel bad."
>

I think you said the word: serialization. And especially *deserialization*,
e.g. from a JSON payload into a typed DTO *without* calling the constructor
(then the DTO is passed through validation, which must handle uninitialized
typed properties "gracefully").

-- 
Guilliam Xavier

--000000000000f8195305c33e044b--