Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114614
MIME-Version: 1.0
References: <CAOwTYAtc_xD6n=efmamkAy4ro4KqPKxq18-zXsNriY0280FY2g@mail.gmail.com>
 <CADyq6sKZoC0GWE__=ODENUmOr+wrzCiNr7ZBuRgurpPacSU+VA@mail.gmail.com> <CAOwTYAvZ+PMK74571Om=7z0kxsOMU4ceAnf2eKPQFCwGTnMGMg@mail.gmail.com>
In-Reply-To: <CAOwTYAvZ+PMK74571Om=7z0kxsOMU4ceAnf2eKPQFCwGTnMGMg@mail.gmail.com>
Date: Wed, 26 May 2021 13:49:34 +0200
Message-ID: <CADyq6sK04A9U2SaCj4vwYkkDL2MJqGT3X0_d8hja4ZMFhLq1Lg@mail.gmail.com>
To: Joe Watkins <krakjoe@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000036add105c33a3d54"
Subject: Re: [PHP-DEV] Consensus Gathering: is_initialized
From: ocramius@gmail.com (Marco Pivetta)

--00000000000036add105c33a3d54
Content-Type: text/plain; charset="UTF-8"

Hey Joe,
<http://ocramius.github.com/>


On Wed, May 26, 2021 at 12:56 PM Joe Watkins <krakjoe@gmail.com> wrote:

> Hi Marco,
>
> What do you mean by "meaningful benchmarks" ?
>
> There's no question that is_initialized will be faster than the reflector
> version, even with reflection caching.
>

Ack, but real-world impact seems irrelevant? I've worked on stuff that
heavily relies on checking initialized state, and most of it is mostly
unaffected.
"meaningful benchmark" means "here's a use-case that really needs
`is_initialized()`, and absolutely cannot run into the penalties of
`ReflectionProperty#isInitialized()`


> Here's a naive bench:
> https://gist.github.com/krakjoe/cef6452281624bdf1b46788f52a01521
>
> krakjoe@Fiji:/opt/src/php-src$ sapi/cli/php initialized.php
> is_initialized: 0.04558 seconds
> reflection: 0.07186 seconds
>
> However is_initialized has a narrower scope than the reflector version, as
> mentioned in the PR, it specifically can only work on typed (accessible
> from calling scope) properties.
>

Sounds weird? Why would a narrower version be needed at all?

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

>

--00000000000036add105c33a3d54--