Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114604
MIME-Version: 1.0
References: <194DA850-19F7-41C4-97CF-944F13B57AFD@cmpct.info> <7AD8D5D3-C70E-40C3-B55E-A4C9E4ECDA44@cmpct.info>
In-Reply-To: <7AD8D5D3-C70E-40C3-B55E-A4C9E4ECDA44@cmpct.info>
Date: Tue, 25 May 2021 23:43:10 +0100
Message-ID: <CAFPFaMKJqf0=PsnXHXMK9T=e87jS_LE_Cbph3ZWu3bq3tmhZWw@mail.gmail.com>
To: Calvin Buckley <calvin@cmpct.info>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c5f1b705c32f4079"
Subject: Re: [PHP-DEV] Using clang-analyzer with PHP: experiences?
From: george.banyard@gmail.com ("G. P. B.")

--000000000000c5f1b705c32f4079
Content-Type: text/plain; charset="UTF-8"

On Tue, 25 May 2021 at 21:10, Calvin Buckley <calvin@cmpct.info> wrote:

> I did some additional research and seemed to have decent luck with
> slamming a construct like this after the includes:
>
> #define emalloc  malloc
> #define erealloc realloc
> #define ecalloc  calloc
> #define estrdup  strdup
> #define estrndup strndup
> #define efree    free
>
> One could wrap it around `__clang_analyzer__` or such. Unfortunately, this
> is kinda ugly; it emits compiler warnings, but I suspect this probably
> belongs in PHP itself or perhaps in some kind of clang-analyzer addon that
> handles the e* allocation functions as well as things like mismatching them.
>

Isn't this handled by the GCC 11?

The existing malloc
> <https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/Common-Function-Attributes.html#index-malloc-function-attribute>
> attribute has been extended so that it can be used to identify
> allocator/deallocator API pairs. A pair of new -Wmismatched-dealloc
> <https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/Warning-Options.html#index-Wmismatched-dealloc>
> and -Wmismatched-new-delete
> <https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/C_002b_002b-Dialect-Options.html#index-Wmismatched-new-delete>
> warnings will complain about mismatched calls, and -Wfree-nonheap-object
> <https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/Warning-Options.html#index-Wfree-nonheap-object>
> about deallocation calls with pointers not obtained from allocation
> functions. Additionally, the static analyzer will use these attributes when
> checking for leaks, double-frees, use-after-frees, and similar issues.
>
From: https://gcc.gnu.org/gcc-11/changes.html

Best regards,

George P. Banyard

--000000000000c5f1b705c32f4079--