Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114593
MIME-Version: 1.0
References: <CAF+90c9zifA=aq=SM8-iP3b0gzHy2uR_zrH8OCF4ECLu6-tWdg@mail.gmail.com>
 <CAAKU0unQZBdBL0_=iZPEUMfrmdqbevUfTUsTOPTvA_5GiDn5vw@mail.gmail.com>
In-Reply-To: <CAAKU0unQZBdBL0_=iZPEUMfrmdqbevUfTUsTOPTvA_5GiDn5vw@mail.gmail.com>
Date: Tue, 25 May 2021 16:43:12 +0200
Message-ID: <CAF+90c_U_KESFjGLJcY__i=GN5MZnFsWLtYY6pc8J7RNaX919A@mail.gmail.com>
To: Levi Morrison <levi.morrison@datadoghq.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000097085d05c3288c6d"
Subject: Re: [PHP-DEV] Allow combining arg unpacking and named args
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000097085d05c3288c6d
Content-Type: text/plain; charset="UTF-8"

On Tue, May 25, 2021 at 4:36 PM Levi Morrison <levi.morrison@datadoghq.com>
wrote:

> On Tue, May 25, 2021 at 8:18 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
> >
> > Hi internals,
> >
> > Currently, argument unpacking (...$foo) cannot be combined with named
> > arguments (foo: $bar) at all. Both func(...$args, x: $y) and func(x: $y,
> > ...$args) are rejected by the compiler.
> >
> > https://github.com/php/php-src/pull/7009 relaxes this by allowing
> > func(...$args, x: $y). The named arguments are required to come last,
> > because this automatically enforces the invariant that named arguments
> must
> > be sorted after positional argument.
> >
> > Are there any concerns with relaxing this restriction?
> >
> > Regards,
> > Nikita
>
> How do named parameters interact with the variadic parameter?
>
>     function f(...$params) { var_dump($params); }
>     $args = [1, 2, 3];
>     f(...$args, params: [4, 5, 6]);
>

Ah, I think I should have mentioned that the proposed change doesn't
actually allow you to do anything new or different -- it only removes an
arbitrary syntactical limitation. In particular

    func(...$args, x: $y)

will behave the same as

    func(...[...$args, 'x' => $y]);

with the only difference that if $args already contained an 'x' key, that
would be an error, instead of silently ignored.

So to answer your question: Variadic parameters are not targetable by named
parameters, so what you wrote will pass [1, 2, 3, 'params' => [4, 5, 6]] as
usual.

Regards,
Nikita

--00000000000097085d05c3288c6d--