Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11453 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90493 invoked by uid 1010); 21 Jul 2004 22:58:08 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 89547 invoked from network); 21 Jul 2004 22:58:00 -0000 Received: from unknown (HELO gw2.emini.dk) (192.38.9.232) by pb1.pair.com with SMTP; 21 Jul 2004 22:58:00 -0000 Received: from blaster (gw1.emini.dk [212.242.124.121]) by gw2.emini.dk (Postfix) with ESMTP id D207A37C29; Thu, 22 Jul 2004 00:57:59 +0200 (CEST) Message-ID: <007201c46f76$a6468500$0a00000a@blaster> To: "Michael Sisolak" , References: <20040720215525.63006.qmail@web13423.mail.yahoo.com> Date: Thu, 22 Jul 2004 01:01:25 +0200 Organization: Emini ApS MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.3790.181 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.181 Subject: Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929) From: edink@emini.dk ("Edin Kadribasic") Hi Micheal, I have applied the fix to the CVS. Edin ----- Original Message ----- From: "Michael Sisolak" To: Sent: Tuesday, July 20, 2004 11:55 PM Subject: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929) > I believe that a bug was introduced with version 1.3 of php5isapi.c. > The sapi_isapi_read_cookies() function used to return NULL when there > were no cookies, but was changed to return "" instead. That's fine, > but then HttpExtensionProc() attempts to free the non-ealloc'ed empty > string and dies with an Access Violation. I believe this is the issue > people are seeing in bug #28929. > > I've attached a patch for the PHP_5_0 branch that has > sapi_isapi_read_cookes() return an empty_string constant, and uses > STR_FREE to call efree() to protect the case of the empty_string value. > For HEAD this patch would be easier becuase of the recent removal of > empty_string - just return STR_EMPTY_ALLOC() and keep the efree() as > is. > > Michael Sisolak > msisolak@yahoo.com > > > > > __________________________________ > Do you Yahoo!? > New and Improved Yahoo! Mail - Send 10MB messages! > http://promotions.yahoo.com/new_mail > ---------------------------------------------------------------------------- ---- > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php