Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11450 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58295 invoked by uid 1010); 21 Jul 2004 21:25:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 58211 invoked from network); 21 Jul 2004 21:25:47 -0000 Received: from unknown (HELO iko.gotobg.net) (80.168.8.116) by pb1.pair.com with SMTP; 21 Jul 2004 21:25:47 -0000 Received: from pd95e98cf.dip.t-dialin.net ([217.94.152.207] helo=[192.168.0.32]) by iko.gotobg.net with asmtp (Exim 4.34) id 1BnOb1-0006lb-JN; Thu, 22 Jul 2004 00:25:51 +0300 Message-ID: <40FEFAB7.20602@hristov.com> Date: Wed, 21 Jul 2004 23:22:31 +0000 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040627 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Cristiano Duarte CC: internals@lists.php.net References: <20040720192358.26985.qmail@pb1.pair.com> <40FE3918.1000804@hristov.com> <20040721170125.54624.qmail@pb1.pair.com> <40FEBF1C.5040409@hristov.com> <20040721174731.64019.qmail@pb1.pair.com> In-Reply-To: <20040721174731.64019.qmail@pb1.pair.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - iko.gotobg.net X-AntiAbuse: Original Domain - lists.php.net X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - hristov.com X-Source: X-Source-Args: X-Source-Dir: Subject: Re: [PHP-DEV] array_intersect_key From: php@hristov.com (Andrey Hristov) Cristiano Duarte wrote: > Andrey Hristov wrote: > > >> Hallo Cristiano, >>these 2 function will be added to HEAD in few minutes. I see that the >>patch is kind of trivial and won't hurt anything :) (INTERSECT_KEY >>is just INTERSECT_ASSOC but no data comparison performed). >>I will add also array_diff_key() and array_diff_ukey() > > I changed the function name from array_udiff_key to array_diff_ukey. > Is this ok ? Patch attached. > Well, my patch for array_diff_key() and array_diff_ukey() looked like yours but when writing the regression tests I spotted a bug. I thought it is not related to the new functions. After some testing I found the problem and it was related to array_diff_*key(). I have placed a comment in the source at about line 3364. cheers, andrey