Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114448
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
In-Reply-To: <CAF+90c8X-PUjVq0r10qLg1-Op1SoJbdRbLKgXwvgg=W29CYUiQ@mail.gmail.com>
Date: Wed, 12 May 2021 10:39:26 -0500
Cc: php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <BF0E4999-21F2-4991-9D47-44DDB3324E24@trowski.com>
References: <CAF+90c8X-PUjVq0r10qLg1-Op1SoJbdRbLKgXwvgg=W29CYUiQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Subject: Re: [PHP-DEV] Disable interactive mode (-a) if readline not available
From: aaron@trowski.com (Aaron Piotrowski)


> On May 12, 2021, at 3:12 AM, Nikita Popov <nikita.ppv@gmail.com> =
wrote:
>=20
> Hi internals,
>=20
> If the readline extension is enabled, PHP provides an interactive =
shell
> under -a. If it is not enabled, it falls back to an "interactive mode"
> (yes, the difference between "interactive shell" and "interactive =
mode" is
> important here). The interactive mode is simply an stdin input, which =
needs
> to be terminated using Ctrl+D. You can only run one script that way.
>=20
> I think the current behavior is quite confusing, because it's really =
not
> obvious that you ended up in this fallback mode (you need to know the
> difference between "shell" and "mode" in the output) and most people
> wouldn't know what to do with it. The latest instance of this is
> https://bugs.php.net/bug.php?id=3D81033.
>=20
> I think we would be better off disabling -a completely if readline is =
not
> available, and exit with a helpful error message. I've opened
> https://github.com/php/php-src/pull/6976 to that effect. Does that =
sound
> reasonable?
>=20
> Regards,
> Nikita

This would have been helpful several years ago when I started compiling =
PHP myself and was confused why `php -a` broke. An error message would =
have saved me some time. So yes, please, merge it.

Aaron Piotrowski=