Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114380
To: internals@lists.php.net
References: <CAF+90c-HY-0fx+pTmntRJZKcQcZFfk3uJwrZ6FAMAx5_Wj+JHw@mail.gmail.com>
 <CAAwdEzApyQd52RpJ-gW+pNtBA=jA1bn74c-K1djcztRRgaYAag@mail.gmail.com>
 <CAF+90c8YMpGNLKehfFW6gWJx0mGUVqL0Rx+U262gGRP6cTXBgw@mail.gmail.com>
 <CAAwdEzDwD5sc6AQxLSnj0Dx=4ZsP1h0K83TS+jyN1x5_X7NAAg@mail.gmail.com>
 <CAF+90c9_=GkKbErf-z464_zqAHCDERbdLjd_uyoNvC9PERxoxQ@mail.gmail.com>
 <CAF+90c_WVD3jDtrtVbAuPGPWf9v6Hz4h2i=nrgHi+4Axx4157Q@mail.gmail.com>
 <CAF+90c9WXzqVnJ-U6Sj=xP39rEn03FDksdLG85T=e_+ZhdCXTA@mail.gmail.com>
 <CAF+90c_YSo_W6twktGg0nZ16Tr+qx_xsEucsOSdh6=uS8kTSAQ@mail.gmail.com>
 <3f3cb374-23d8-9d26-4ea2-fe891538a7b6@gmail.com>
Message-ID: <47e8f7c7-6ae6-3744-b590-c3f39b144c46@gmail.com>
Date: Tue, 11 May 2021 14:57:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <3f3cb374-23d8-9d26-4ea2-fe891538a7b6@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] New in initializers
From: rowan.collins@gmail.com (Rowan Tommins)

On 11/05/2021 14:12, Dik Takken wrote:
> So the use of "new" in initializers would require extending this base
> class and call the parent constructor. Maybe forgetting to do so could
> throw, preventing initializers from silently not working.


If we managed to get that working, I wonder if we could also include a 
check for uninitialized typed properties, a bit like Swift's "two-phase 
initializers". In short, make this throw an error:

class Foo extends \PHP\Base {
     private Logger $logger;

     public function __construct() {
         parent::construct(); // "Error: Property $logger has no default 
and was not initialized before calling Base constructor"
     }
}

This would catch bugs closer to their source, where currently there is 
no error until $logger is accessed.


However, the "if" at the beginning of this message is quite a big one: 
it's not obvious where to assert any of this, because the constructor is 
just called as a normal method *after* the engine considers the object 
to be "created".


Regards,

-- 
Rowan Tommins
[IMSoP]