Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114331
MIME-Version: 1.0
References: <1620635361.9147.0@gmail.com> <CADyq6s+CMbj2YYs7MUXXCKc1iAQJQFA4HPC6bH_qa-XwG5FQKQ@mail.gmail.com>
 <CAAEi=BN-cX3WfmJ=GSByZOD20ry86iztr87Js6_AUBevKXCcqg@mail.gmail.com> <CADyq6s+4up_gJ_CaX1egkfAGSEWR-zSR3W=mC6dW8sdhz_3ZeA@mail.gmail.com>
In-Reply-To: <CADyq6s+4up_gJ_CaX1egkfAGSEWR-zSR3W=mC6dW8sdhz_3ZeA@mail.gmail.com>
Date: Mon, 10 May 2021 11:12:05 +0200
Message-ID: <CAAEi=BP1_hfq_Ty3Q1st808fMZrUO9Xyotuh+L3J9kk2PYKTVg@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000fc401b05c1f62dcf"
Subject: Re: [PHP-DEV] [RFC][Draft] Body-less __construct
From: mrtreinis@gmail.com (=?UTF-8?Q?Mat=C4=ABss_Treinis?=)

--000000000000fc401b05c1f62dcf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I don't necessarily agree with this point in particular - I mentioned PSR
just-by-driveby, since whoever does follow that convention will face this
issue - but the scope of the proposal is not limited to PSR adopters. It's
also worth pointing out that PSR is not an "official" coding guideline for
PHP, and therefore we should probably not limit the scope to it, simply
because regardless if the brackets are on the same line or not, they are
still there.

IMO, this is a language issue - topical, cosmetic, and minor - but language
issue nevertheless, in fact, exactly like the one had for attribute syntax.

Let's gather some feedback and see.

- Mat=C4=ABss


On Mon, May 10, 2021 at 10:55 AM Marco Pivetta <ocramius@gmail.com> wrote:

>
> On Mon, May 10, 2021 at 10:50 AM Mat=C4=ABss Treinis <mrtreinis@gmail.com=
>
> wrote:
>
>> Hi Marco,
>>
>> I am not sure, that's why I am asking for feedback.
>>
>> I have been converting a ton of code to use constructor property
>> promotion and the absolute majority ends up with the method body being
>> empty. I reckon this could be a nice eye-candy to have, however, it's
>> nothing more than that.
>>
>> Another point to be made here, as far as my interpretation of PSR-12, th=
e
>> curly braces occupy two lines for methods with multiline arguments. So f=
or
>> whoever follows PSR-12, it's more like this, with brackets just dangling
>> there across 2 lines.
>>
>> [...]
>> class Foo {
>>     public function __construct(
>>         private Bar $bar,
>>         private Baz $baz
>>     ) {
>>     }
>> }
>>
>
> Given that:
>
>  * `{}` can already represent what you want
>  * the issue is more of a coding-style related topic
>
> I suggest bringing this up in a new PSR instead. Consider that PSR-1,
> PSR-2 and PSR-12 were designed pre-PHP-8, so they will need adjustments
> again, but AFAIK nothing has moved yet, since the ecosystem is still
> adapting to the PHP 8 changes (I myself haven't finished adopting it on
> many of my libraries).
>
> If this is relevant to you right now, add an exclusion to your
> `phpcs.xml.dist` instead: easier and less painful than expanding the
> language for such a tiny detail.
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
>

--000000000000fc401b05c1f62dcf--