Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114327
MIME-Version: 1.0
References: <1620635361.9147.0@gmail.com> <CADyq6s+CMbj2YYs7MUXXCKc1iAQJQFA4HPC6bH_qa-XwG5FQKQ@mail.gmail.com>
In-Reply-To: <CADyq6s+CMbj2YYs7MUXXCKc1iAQJQFA4HPC6bH_qa-XwG5FQKQ@mail.gmail.com>
Date: Mon, 10 May 2021 10:54:50 +0200
Message-ID: <CAPyj-LBFotW2QczniE02Ex8T2Fp-GnJtCqccZMh==hoC3vOeAw@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC][Draft] Body-less __construct
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi internals

On Mon, May 10, 2021 at 10:32 AM Marco Pivetta <ocramius@gmail.com> wrote:
>
> Hey Mat=C4=ABss,
>
> This already works by replacing `;` with `{}`: https://3v4l.org/tN4HM
>
> Is the change in AST really necessary, considering that?

The root problem is not that {} is significantly worse than ; but it's
that some cs tools require obnoxious formatting.

```
class Foo {
    public function __construct(
        private Bar $bar,
        private Baz $baz
    ) {
    }
}
```

I agree with Marco, it makes more sense to fix the cs guidelines
rather than to adjust the language just to work around it.

Ilija