Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114326
MIME-Version: 1.0
References: <1620635361.9147.0@gmail.com> <CADyq6s+CMbj2YYs7MUXXCKc1iAQJQFA4HPC6bH_qa-XwG5FQKQ@mail.gmail.com>
In-Reply-To: <CADyq6s+CMbj2YYs7MUXXCKc1iAQJQFA4HPC6bH_qa-XwG5FQKQ@mail.gmail.com>
Date: Mon, 10 May 2021 10:49:39 +0200
Message-ID: <CAAEi=BN-cX3WfmJ=GSByZOD20ry86iztr87Js6_AUBevKXCcqg@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c368a005c1f5ddb7"
Subject: Re: [PHP-DEV] [RFC][Draft] Body-less __construct
From: mrtreinis@gmail.com (=?UTF-8?Q?Mat=C4=ABss_Treinis?=)

--000000000000c368a005c1f5ddb7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Marco,

I am not sure, that's why I am asking for feedback.

I have been converting a ton of code to use constructor property promotion
and the absolute majority ends up with the method body being empty. I
reckon this could be a nice eye-candy to have, however, it's nothing more
than that.

Another point to be made here, as far as my interpretation of PSR-12, the
curly braces occupy two lines for methods with multiline arguments. So for
whoever follows PSR-12, it's more like this, with brackets just dangling
there across 2 lines.

[...]
class Foo {
    public function __construct(
        private Bar $bar,
        private Baz $baz
    ) {
    }
}



- Mat=C4=ABss


On Mon, May 10, 2021 at 10:31 AM Marco Pivetta <ocramius@gmail.com> wrote:

> Hey Mat=C4=ABss,
>
> This already works by replacing `;` with `{}`: https://3v4l.org/tN4HM
>
> Is the change in AST really necessary, considering that?
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
>
> On Mon, May 10, 2021 at 10:29 AM Mat=C4=ABss Treinis <mrtreinis@gmail.com=
>
> wrote:
>
>> Hi everyone,
>>
>> Since constructor property promotion is now implemented, and it looks
>> like it could become a widely used feature, I am proposing a small,
>> cosmetic change in syntax for constructors in concrete classes to do
>> away with empty constructor body.
>>
>> Here's an example of how this would work:
>>
>> <?php
>> namespace App;
>>
>> class Foo {
>>     public function __construct(
>>         private Bar $bar,
>>         private Baz $baz
>>     );
>> }
>>
>> Some notes to this:
>>
>> - Since this is similar to already existing syntax for body-less
>> methods, parser should not be affected that much. I hope. I really have
>> no idea.
>> - Syntax would be optional - meaning, you can as well continue using
>> empty body, just that in this case the body would be implied empty.
>>
>> Thoughts?
>> Regards,
>> - Mat=C4=ABss
>>
>>

--000000000000c368a005c1f5ddb7--