Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114297 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 59483 invoked from network); 8 May 2021 00:00:41 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 8 May 2021 00:00:41 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 68DFE1804C8 for ; Fri, 7 May 2021 17:07:35 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 7 May 2021 17:07:34 -0700 (PDT) Received: by mail-ot1-f54.google.com with SMTP id q7-20020a9d57870000b02902a5c2bd8c17so9391245oth.5 for ; Fri, 07 May 2021 17:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wY3I1qp/cmNSadn1eoCZRwnIT9cWE7ejZTsgu1nohVE=; b=uziPdBNEuPOYC/ku2HPX/rP+UNXpyGGwDS2mNWtU7x9cFeUirAu9DYJsiYCVfJnQ52 /ar4WpdAKUBFHHm40G2lBLI0aIhz/t+DTaV7dZ65NyMfzjjzeoFWDwTZuUfTddl6NllW YN0BjA4L6FQRqMmQM4As2ve75pOlj2yym+Gne4GdhyllgIH9w41m62ptsj8+iuxTIQpU TVy6QuH5WPC06OHnku13YaNGqgBUO7SgW71azdmPjeFf9cjX/0+PSWFaRVGUOTLHGLFo tLA2RRooofla4kW8eaCu3E+6CDQ+tkxHN16fLSo9/aUfBzWe4POWxzihtpP2IRB7WtUO dNGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wY3I1qp/cmNSadn1eoCZRwnIT9cWE7ejZTsgu1nohVE=; b=L6Adqw7uL6HjwDiqdltMaPA6s6Ha0ar4F7kWMquKDlBCog+jyl86Gd3gIwUeg/Z1YS EsluMZ7BVrY1NSTQl3js1BY7Xa2tIJa8NLKkqz6v49O9KhN+jaxOF9yoHA0t1GJdiF31 Q9F0Is7cZisImbCaKQO0UGW3XjDI/XCb3ziNOdNoiUixPC3dtjXM7tgxM40yBByi5jjh w4nbOAuYV+jm3T51MPocFjKACPFEi6SI6Vx8T/SiMykHfk4Wb8j3UqFPmmauoCxXZd4g rr4Gc9mOqspU6QCNaDiSgqwtz5QnoEcKMHvmt0Rgv0KEEkqRG7UZtDph6vTBiL3E9tB9 N71g== X-Gm-Message-State: AOAM532nETy3CqPA8936Ssp5ZTTRjL9tc3ERcA8UvdNoyxjMSqfgcZKs tKC4oDc2X4LegXjBaNr0BMsFmETIhbNw8Tdus0frbNNwB7k= X-Google-Smtp-Source: ABdhPJyG28EvZbUcxhJJQHAsl4Oc9GEYOh6gVxEzHmvzaFTJr4FGhwDVYs6a8ZqcNbNEDZ2g150AwNoiKtr9tJeNOCA= X-Received: by 2002:a9d:6a88:: with SMTP id l8mr10813326otq.236.1620432453272; Fri, 07 May 2021 17:07:33 -0700 (PDT) MIME-Version: 1.0 References: <480BB785-0064-46D4-B705-B5E71D2DC0CC@cschneid.com> <6095c9a6.1c69fb81.5884c.07beSMTPIN_ADDED_MISSING@mx.google.com> In-Reply-To: <6095c9a6.1c69fb81.5884c.07beSMTPIN_ADDED_MISSING@mx.google.com> Date: Sat, 8 May 2021 01:07:22 +0100 Message-ID: To: Ben Ramsey Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000c289e405c1c65422" Subject: Re: [PHP-DEV] PR for minor bugfix in compact() From: davidgebler@gmail.com (David Gebler) --000000000000c289e405c1c65422 Content-Type: text/plain; charset="UTF-8" Great, that's been updated, build in progress (relevant tests passing locally). I'd have preferred TypeError but appreciate there being a consistent convention to follow. These kind of small fixes are also about me becoming more familiar with typical conventions in the engine - some of this stuff is just not stuff you'd find out until you stick up a PR and get feedback from more experienced contributors so it's all good to know. Dave On Sat, May 8, 2021 at 12:13 AM Ben Ramsey wrote: > Christian Schneider wrote on 5/7/21 02:06: > > I agree with George that it should be an E_WARNING first and then > changed to a TypeError in PHP 9. > > This should be the default process for reasons given in many other > threads about tightening type rules IMHO. > > > > So no, I'd prefer if this PR to be changed to E_WARNING before merging > it. > > > > - Chris > > > > Not a lot of chatter about this on the list, but I also agree that this > should be an E_WARNING in 8.1 and promoted to a TypeError in PHP 9. This > is our standard process. > > David, please update the PR, and we'll get it merged. > > Cheers, > Ben > > --000000000000c289e405c1c65422--