Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114296 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 55459 invoked from network); 7 May 2021 23:06:45 -0000 Received: from unknown (HELO localhost.localdomain) (76.75.200.58) by pb1.pair.com with SMTP; 7 May 2021 23:06:45 -0000 To: internals@lists.php.net References: <480BB785-0064-46D4-B705-B5E71D2DC0CC@cschneid.com> Autocrypt: addr=ramsey@php.net; keydata= mQINBGCHQTYBEAC6IU9aXEpVuLJNAzXwL7q9Vt1PkxJHr7kJynUg/3ISrOdJy2Ebola7GbEd vLZ69o+NbsL5vmOmT2AD0pEGfMgE9KWJ122iEfN4hrWThz+sHcVd/TKX9E98g+HTpoJGtYcp 6jYxG0YRP7dn1zSn9CawVJpMsoS2G0JZB/q2lIELoPRLMjicRDBEfamTPi3vyYiuf4vvCcYY z3AEMYirt5f7rBrVOs3FVBozEqrN2fPRWvFgTnhsQ8MEiq5/DMsnxFq2wgheAKPIAXhZiJFo KHsrpiAANEmGZBY2pbW05rBY1ZmJpi1yCrSk582cdPo2Ca+NrNEPJ9spoEinAtApp/orirJY bjKViWqmh7mYYyv/NAQKwGBE1up3tSGVj0rKG3f9seLvYsApHf0lhEQN/ypzC+pYDlSXzWxc Q8bifixb6XulaEgB5XOHwuvpTK6HoNNdZM44Fl+B/eAXaebL6Vh0P1EN/2DBr4FGNb8vlXdv Gxs7rJbJ8+aNmYeNIdg5qbYubNsO2fU7yw9kTDNTej63Ql1a0Md2wfZze8dZy6LJ/tL//IH3 JPd0jvT1y0LVIKoYVrIfv06zolVplqi72zfec1kpw0VR6dT/LyhBlyNumqJMRHdZlX4pUCpx 79pOonjHNTNuhjOPLlzai0ooWBtloDZfNGoFRVNNJv/hGvVM+wARAQABtBtCZW4gUmFtc2V5 IDxyYW1zZXlAcGhwLm5ldD6JAlQEEwEIAD4WIQQ5tkE0PYwQSysUbcP5w53AuWmFRAUCYIdB NgIbAwUJBr8a7wULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD5w53AuWmFRMyWEACO9nAp /ahKv7UQfZ/bdNgj4BbSyVRQSCSH1ngkS0LL9r5qlhmvXoarD0943dMk6jbFdoUU5M7zZ62y EFLR20QJtqTc+O+ApXCB7qm3ZO4MH8hB8Nr1qRLYlUx2yQNWqkMqQawo3XybdLOucIOB0qaH UnpSTgNLIVgYQYUoFOJFL8SSj03BdVDOYgI5pvDlSEC1HmQyxTCVehQB5jhtCZrxjIT6dR3d 2HTYMsoZRdSa6sfzCvnkQV210gDEUpgblHFeadem5LdQkP71OTcItwdhxabL2uY+v/TWa+Fe avItg3uAsiKV499X7Co34LN5NkoSA1Ieq78coZAh6tY6nOb2EpbZxfWyBIbfzJ9/Ny1KC/rw Xo2P1CESkoU7eniupXJwMWv7o2+Jzb6D/lBhwrE0XDSvraLow8UmBdZyNMxxigpjUZhMo1ui qeHjbKaDZJvHQMBmhL4L1TTOSaOcwCP4uIwTteJRu6k1YR9a1VBTlAyjPhzA+gHYjkqdnV15 mOV2uDjCfKlmzxFED/6sxXXHkC/2I5s00DmqK4QHQf9lCz4gdF4Uiabs9x0ntCbs/LAVQqWm wEB5PPvsnTn1kW+4UdaMUuqiYtkyJU+bzkel/L+JHHMZr6EEG50nVVEx0oG6f4n1RSE3pPEW 3vWjUZ7uIvjTpCoAN7MIM5ZCXCnwxrkCDQRgh0E2ARAA2NPzmrdm/BA3DUijyTXcq0JQ0Pjd n8k26tVz04U3uX950U9Y3qWKn7Iv4uP+q82tgDL8sTzuwEErB2JQWB8XHKgh9kPdIwk7u4lC clOuSsd2mQt1O1ROPo5fNVuf2+aqo72TUcS4A2Q57zu4QRYe2/o4+8dQAbB3cKvs145oNpiQ gbA+G2uY0Gj6/p4q74a/2O+OJhqWlVkZYO3fy4S+9xkcueOg4AlXo4HeerzLIthwctgSrY8S K9p3dsiZ9dvgOcnp7moDlacnvBeQ8u1CxSeomHtfzaaFZ8oqb95tIROAtMdbyMPLYl0fOXG9 GhrmIIzoBMiwhPSDZjENGWXdSamcCtiMlostJwzVSV6pM3N2I2GXK2IgW/HVe5LwH9BPlJ4i GE2LQVNqzlgTN2k0+OyYen7bLP7UOHtBy3h2ab6VsCbZDx29Yxg/9PInGR+F8lcSJRDIc4rg GXQQ06+7+8Upqj68OPWn1ol30TldNY/eLRXbxePMAziG96iAQW7DXXajLxz00oatsDB5Z8pV RTP9AiZ/8sXswXLkH0VVnh4O5W80rdBw9vXwc+zJcaDknrJiQjfrMKEsuJ2dZ4VjRxGkYd9l Z9h9quMmtK2RRB5Nn0ullgTE4e3I4p5pJUFcQIQffXfhGAmeEh7u+ALbOC7wLHScHuSPW5Ti K2HnMDcAEQEAAYkCPAQYAQgAJhYhBDm2QTQ9jBBLKxRtw/nDncC5aYVEBQJgh0E2AhsMBQkG vxrvAAoJEPnDncC5aYVELfkP/j1gVRT5dOfk2yQRftcshV3h91RY3c8MCl/s+RYBXLjv7seE 8nn/Z1VG6IiPcwsBJYnM5Y8oaPvvlLc29shu7D8MLJbPS3jgN3m+MvaU7I6hH7u4xiG7SCFB qj7Xre8eJuToN/Ksl5wBVGic+iSYham4XpHjZEjyv5iH8ksZHhwQosiLr1ogEGBcwWDeg7Di hI41tB82siqKHyhOn06Jmir1DS7OXoMr6biUAPo7Rf1BTFh18BNVBfgrGApgUUfLlX32Myrd TwCVdxyoUYHK71LncaDDbCH5fFRZUHguktC92Sv8smFtoRco6SxGMKyG0g0V82cnpIQtdneT EVaaPsajIaGRmIkpBRw373nY4e4bRL4yxAz7aJW82U23awhUzZym05FQFe8+ksdgGgV+rQj1 8nKkXiNZwdR6hhSzlvc0+GuxWgwMtKPIJU8fBET42yAcvUdYSCAeXsMgAD9X3huV37o+qlZu yJRC737dZBrwdIJvZN1/oZ28CFc84LxrjL5efjbpqw/FXKCe1L47BQ0bL6RyCe8y9qxKeF2f EML6jkrmH28VkkyaFuabMsh7qwQuGReu2BQywdD4ivwsgeFcWB3u/RlOcpDfq/EkdXmrzZ3Y VBaPeCN0EPvffcdA7zoUueFI+JConWbme9Mg3oe++tcDvMKlr0HUGVFVCwkF Date: Fri, 7 May 2021 18:13:36 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:52.0) Gecko/20100101 PostboxApp/7.0.48 MIME-Version: 1.0 In-Reply-To: <480BB785-0064-46D4-B705-B5E71D2DC0CC@cschneid.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iGG4HGSrPrEU9vLKcaSaahdwqQELgWLdJ" X-Posted-By: 96.61.105.82 Subject: Re: [PHP-DEV] PR for minor bugfix in compact() From: ramsey@php.net (Ben Ramsey) Message-ID: --iGG4HGSrPrEU9vLKcaSaahdwqQELgWLdJ Content-Type: multipart/mixed; boundary="sxcNF8W9M6bNp7a2IhCKiyR23e8gzdKQH" --sxcNF8W9M6bNp7a2IhCKiyR23e8gzdKQH Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Christian Schneider wrote on 5/7/21 02:06: > I agree with George that it should be an E_WARNING first and then chang= ed to a TypeError in PHP 9. > This should be the default process for reasons given in many other thre= ads about tightening type rules IMHO. >=20 > So no, I'd prefer if this PR to be changed to E_WARNING before merging = it. >=20 > - Chris >=20 Not a lot of chatter about this on the list, but I also agree that this should be an E_WARNING in 8.1 and promoted to a TypeError in PHP 9. This is our standard process. David, please update the PR, and we'll get it merged. Cheers, Ben --sxcNF8W9M6bNp7a2IhCKiyR23e8gzdKQH-- --iGG4HGSrPrEU9vLKcaSaahdwqQELgWLdJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEObZBND2MEEsrFG3D+cOdwLlphUQFAmCVyaAACgkQ+cOdwLlp hUQxsw//c+waVdjcRIUmO1ASKOo7+xZh2yHG3UXh+G2s16p+krplvkJrYiHIp4Nh nbC6lpChkomj8iQZp+BJX94y+srNEm2olZe2RBNDecFS0ZyxQbja2EUuIW4hckDS inqlFpWDpUhMAsXn5ymPMud/aj4I0Cmu2OfsflQEgdslA3F+vs5cYvXN7xcRY2K4 Qs84xq3NxfdqfOz2MAPGoB5bu1gklwIa6b1rbCfP8gFTyrnwqyBGJs9FmZ7Zp6rG 6A4SdjeV1YDLb5weFifKmpJcbFgqkH/VNhd2eyWA2KLDoiuAyM7NPaq+y+TgoAKk zSTV4NgyCvyiCCZCsaarCkksX1od0ygttjaQrLcZhFveRB3gH/5Ss3c/TDHG6kqT T+2X91BEaQdt5yB4hru5rYpDL8AiD2+W25oR5TbzLDOzWvVkS2Q7Ww1BFsBzwiWV wMfgBbJtcsoU+WY1ao0l/Ae/q+3lwM+AvKiVA90bT2GGb7aH7wg0LJwv7Ts6sQ39 61qs4ikK2MRLOYS5Jt/EsQJ4r87bzYK0sc80GLA7uQ1D1qHH6GhI2ZB5VbJ0l2u1 trNZq2oL7iwXJsJoxN1aeQkC1YzuPnDfRUnifBXQNKMFtoII0CQEQ1/AofFNI/1Q 2/upUUmhSjeYCzgJFCr6bHtd7j3V5aIR5kGqfd/WPL1q+DvK/rA= =rB4i -----END PGP SIGNATURE----- --iGG4HGSrPrEU9vLKcaSaahdwqQELgWLdJ--