Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114275
To: internals@lists.php.net
References: <CAF+90c-Aeaf9SfkCZWC-NZ4dy+8HxE2V=7oa94TO2zkAf2kaQQ@mail.gmail.com>
 <CADyq6sLx9239Wp0MfofAjCQYatPiY58Xw0F9-c7qnyhAZ63H9w@mail.gmail.com>
 <CAF+90c_w3bm=nJ3+vSz=6rg4tAETkcND4hos24Cx+ZuXWn5c5A@mail.gmail.com>
 <CADyq6s+JYng9eE-QtV9vfJ3=DsrX1dLMPWXrwvwnJY-=d3UE6A@mail.gmail.com>
Message-ID: <1f89692a-ee16-270c-0a13-8bbe75ef373c@korulczyk.pl>
Date: Tue, 4 May 2021 20:03:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CADyq6s+JYng9eE-QtV9vfJ3=DsrX1dLMPWXrwvwnJY-=d3UE6A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Property accessors
From: robert@korulczyk.pl (Robert Korulczyk)

W dniu 04.05.2021 o 18:32, Marco Pivetta pisze:
> I'd strongly advise killing by-ref array push there: it's an acceptable
> limitation, for the amount of benefit we get :P
> In fact, people doing `__get` now are already familiar with "Indirect
> modification of overloaded property" (https://3v4l.org/6dTXK)

They are familiar, but this is not a reason to cripple property accessors concept with the same limitation as `__get()`. "Indirect modification" is
really annoying, and using reference to bypass it looks more like a dirty hack than real solution. If we can avoid "Indirect modification" for
implicit accessors without involving references, then it is definitely worth it.

And this is important for explicit accessors too - in my case like 90% virtual properties are some kind of conversion between string and array, where
getter returns array generated from string. It would be great to handle this too, even if it will be only syntactic sugar, where
`$object->property['key'] = 'value';` will be equivalent of this dance:

$temp = $object->property;
$temp['key'] = 'value';
$object->property = $temp;


Regards,
Robert Korulczyk