Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114267
MIME-Version: 1.0
References: <CANi74fqG+Qx-mP=o9iTqOx=2h=CYxdKcLUDTHDLEV31Z7gMpRA@mail.gmail.com>
 <CAGBsUrerL=yDkwY=opfd=uDbOFP31-dNfbAhEc9OkE851C76cg@mail.gmail.com>
In-Reply-To: <CAGBsUrerL=yDkwY=opfd=uDbOFP31-dNfbAhEc9OkE851C76cg@mail.gmail.com>
Date: Tue, 4 May 2021 13:13:38 +0200
Message-ID: <CANi74fomGYJEmF-EL7Sfz1wKKdCm1oGfWO+w00_aCBbCt5UsVw@mail.gmail.com>
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003d0b3d05c17f2c84"
Subject: Re: [PHP-DEV] feat(pdo): add `clearParams` method
From: juanrgm724@gmail.com (Juanra GM)

--0000000000003d0b3d05c17f2c84
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Kamil, thanks you for your reply.

I am going to enumerate the answers.

1. `PDOStatement::clearParams` should reset the statament params (
https://github.com/php/php-src/blob/31c74aaeebf3af3c87e3981703f9f775c65600b=
9/ext/pdo/pdo_stmt.c#L406-L410
).
2. Recreate the prepared statement is very cost.
3. SQL engine is choosing bad the search index because I am passing a param
as string insteadof integer.

If you call `PDOStatement::execute` without params, the statement will use
the last params. Don't to clear the last params can be a problem. For
example:

```php
$pdo->bindValue("id1", 1, PDO::PARAM_INT);
$pdo->bindValue("id2", 2, PDO::PARAM_INT);
$pdo->execute(); // id1 =3D> 1, id2 =3D> 2
$pdo->bindValue("id2", 3, PDO::PARAM_INT);
$pdo->execute(); // id1 =3D> 1, id2 =3D> 3
```

If you call `$pdo->clearParams();` before of each `execute`, then it will
throw a fatal error because it won't use the previous params.

The main idea is to overwrite the `PDOStatement::execute` method, using a
custom class (`PDO::ATTR_STATEMENT_CLASS`) for bind values individually
with their types (`bindValue`), but firstly I need call `clearParams`.

El mar., 4 may. 2021 12:18, Kamil Tekiela <tekiela246@gmail.com> escribi=C3=
=B3:

> Hi Juanra,
>
> Thanks for sharing your interest in improving PHP. Your proposal is very
> unclear at the moment. What do you think this function should do? Why can=
't
> you just recreate the prepared statement? What performance hit are you
> talking about?
> I don't see how such a function would be useful, but I hope you can
> explain your use case and its reasoning.
>
> Regards,
> Kamil
>

--0000000000003d0b3d05c17f2c84--