Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114259 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 21029 invoked from network); 30 Apr 2021 16:23:07 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 30 Apr 2021 16:23:07 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 740231801FD for ; Fri, 30 Apr 2021 09:28:11 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail02.x-net.at (mail02.x-net.at [83.65.141.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 30 Apr 2021 09:28:10 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail02.x-net.at (Postfix) with ESMTP id 278BB380055 for ; Fri, 30 Apr 2021 18:28:08 +0200 (CEST) Received: from mail02.x-net.at ([127.0.0.1]) by localhost (x-zimbra02.x [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Rc4eTLp2PGog for ; Fri, 30 Apr 2021 18:28:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail02.x-net.at (Postfix) with ESMTP id 638E8380E86 for ; Fri, 30 Apr 2021 18:28:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at x-t.at Received: from mail02.x-net.at ([127.0.0.1]) by localhost (x-zimbra02.x [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id V2_HAix7xv4m for ; Fri, 30 Apr 2021 18:28:04 +0200 (CEST) Received: from [127.0.0.1] (91.141.3.190.wireless.dyn.drei.com [91.141.3.190]) by mail02.x-net.at (Postfix) with ESMTPSA id AB8C7380E60 for ; Fri, 30 Apr 2021 18:28:03 +0200 (CEST) Date: Fri, 30 Apr 2021 18:28:01 +0200 To: internals@lists.php.net User-Agent: K-9 Mail for Android In-Reply-To: References: <254589645.2058488.1619277132719.JavaMail.zimbra@dafert.at> Message-ID: <5F5830A3-B513-4EEB-A004-93E1D4DB6707@dafert.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [RFC] Add IntlDateTimePatternGenerator From: mel@dafert.at (Mel Dafert) >For both points, I'd say "consistency wins by default=2E" So if the other= classes in that package already skip "Time" and use ::create() instead of = a constructor, you should do the same as well unless there's a very good re= ason not to=2E I have updated the RFC to use switch to the naming without "Time", and add= ed some notes about the naming options=2E (On a side note, I realized that HHVM/Hack also implements it without the = "Time" part: https://docs=2Ehhvm=2Ecom/hack/reference/class/IntlDatePatternGenerator/ ) I have also removed the open question about the `::create()` method, since= the current form is consistent with `IntlDateFormatter`, which is what we = want=2E