Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114229 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 18615 invoked from network); 28 Apr 2021 11:08:21 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 28 Apr 2021 11:08:21 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 6C0C81804D8 for ; Wed, 28 Apr 2021 04:12:52 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_20,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 28 Apr 2021 04:12:51 -0700 (PDT) Received: by mail-ot1-f46.google.com with SMTP id 92-20020a9d02e50000b029028fcc3d2c9eso35530846otl.0 for ; Wed, 28 Apr 2021 04:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=q3KsywSvUn2Mwv1ayGW34zv8tHkuS2/+hmbPJDdPECU=; b=HoxcYZZxGgk5QR2rOCnf/jdXXh1xIz8dJ2t1Rg31QeJbQIzfkAxO60lqTmglQfXIIw hQV1by3vGuYQx8MaNxUYEzlUmehySz4YFCJsqWdECrucJ0i6fPB/SkFP44qciM8AG4Y8 N9OzMRGjZZfFSqyjSFpBNHAomhGfVrjRnt227D8GSIEOZJUqMxMuqFAFAt5iKzXpy2sU eU2ncY6P8Rxb9fuxVT3tdZQpay0DkpazXoGktmtNp+tOi2xTu13mcMG9q4GYaQGeTZcM KfQHSXZeqyKcWH69cBfX/aalWkkwxgkmV+CV3qPjURK3hNty3l2SCYqiSbPe/B28aRYr YXRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=q3KsywSvUn2Mwv1ayGW34zv8tHkuS2/+hmbPJDdPECU=; b=ZxAuCTEMT/r4bRIFeQ+IZHB1HLexzB83iQ+qCymjbGiVzxh9ndrYJX+MmY1znPLnDt RJ5cSSqwR/bQhCqrgvUG0NZJL0wrBw+KUoAyq6z5tUpUrEd1NwElQseLKRzf0dMw5D6i KtK5O8Dw3Z1GZ3QhaG8qzNQQmr0CJP/kJ5zapo+zwDPWjHjHlVxhO8/97XTkWIvNIptY BEzrTm45Z5XZGTDY/bi571mlvF3aaWyWJtAkfEK9B7N+DlC9XMXHPdI5szsBEUu0/FcG YUxIOR0skedco1US/6LyW9DMDwi3g1bPScIwqVzbhnLUwyPL/l/wghECtUk0KlvWbNLA LHuQ== X-Gm-Message-State: AOAM532lEqnXVYX3ftD70Hwzp2YDGJbgNYwBbxeCKG7gXs508sqAbLFV Sp9OQceLCNyKv3asAwEWVmrko76U0MB3jB0H80b3lh6lxuf0Jxik X-Google-Smtp-Source: ABdhPJxBlA8ZyTEyDq4tDyY2QMlajNrfyK1MW3xbua7Hzd1citajdRIesIjHvUHEAD6URI5DAKd8teI5r8QSmiHACMc= X-Received: by 2002:a9d:425:: with SMTP id 34mr23797984otc.25.1619608369262; Wed, 28 Apr 2021 04:12:49 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 28 Apr 2021 12:12:37 +0100 Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary="00000000000086722605c1067525" Subject: [PHP-DEV] PR for minor bugfix in compact() From: davidgebler@gmail.com (David Gebler) --00000000000086722605c1067525 Content-Type: text/plain; charset="UTF-8" Hi internals, I've opened a PR to cause compact() to throw a TypeError if its parameters are not valid, which I consider to be a fix for what is effectively a bug whereby logical errors in user code can be silently swallowed. GPB has done an initial review and left a comment https://github.com/php/php-src/pull/6921#pullrequestreview-646848902 in which he suggests I open this up to the floor, so here it is, seeking your feedback kindly. Also if anyone can clarify what is meant by a warning "will be promoted in PHP 9", I am not familiar with what changes are planned for the next major version? Regards David --00000000000086722605c1067525--