Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114112 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 23738 invoked from network); 23 Apr 2021 19:52:42 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 23 Apr 2021 19:52:42 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 635CF1804E2 for ; Fri, 23 Apr 2021 12:56:03 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 23 Apr 2021 12:56:02 -0700 (PDT) Received: by mail-qk1-f178.google.com with SMTP id q136so29837944qka.7 for ; Fri, 23 Apr 2021 12:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lwQncCWCAgyaHLjMirYSQtZD6SYG3j63JUnGP6r5DvQ=; b=Q4K1i1ZyDGQcV0bmb+QURfEiSt59A2FJOnGhI4iTsqSjeIVoTdkPlBs7apMn38cNUP 4P3LSEN64dfmjsHn185T6yvmSPz+bVhkfV+wzH0S/81GcxEs74ZqR//lnyZq7EYAA1WI xNYc9UHevVckdzN5CpQbO0DOEuYAU5kRjFHHxi4JaHieRMF03i+iDzwraQmDifpEsyN8 tsts5THR7o8/MqNZq+fIgbrCM82JIL8Y5Cvj9wxoSybadIdJyzur/TmYx+b1jihY+W9D h7oCMIhjbrXfhPEZ9c7R1e0A7YWvj71KqQdx7heH0UFtWdZmTQdBktnYAxTHfpcb8B2h zOEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lwQncCWCAgyaHLjMirYSQtZD6SYG3j63JUnGP6r5DvQ=; b=ZHXkuMrYltoZ9zOvCCfT8NN4M/bfIP5YLyGAyxaiYlzgG6var31v4fQm+WMpsTyEQG zsU3H7c0YC5QZjTQ5TPSKqQmtDAIG7YGQZi+QHxL9ZPMAYBNKXc0ql1MMzi0dDBLbCXV q00oZ+zKFmKXptlIDWbycTkh4VSogBTlx8YiXHOhUcZo8mlOCeALp1p50qxBpQGkJ0aX brizpFF+L3vLcManSMfiuIXs2Ef7qHoJEXUeiDyWkc+/7oSSAt7nWMc+5s/B2/7Yi0dc H7r+e54DDdiquJlNOeO9IxNljmtB9rGyrndF48v4mWsTZrc5E+peZUw+mcgCzhyeehqt 2x8A== X-Gm-Message-State: AOAM530ooZmF1/7o1tEYNkw9jr8jRPSY5bh4Nd8Tp7ly/vWl3B3COhFH nu7UephFX71ziO8cC2Ru1P55LdA/Hd2sD5ZXW5pXLjPI5Y4= X-Google-Smtp-Source: ABdhPJzSfybkQ0yP2GuDN/jh7sUS7YoenSU3gwnneAQf8fMQcth23O5pTr6jZH9VckAhD1pa6Ny/tkJKjMSll50TFQA= X-Received: by 2002:a05:620a:215d:: with SMTP id m29mr5780751qkm.342.1619207761419; Fri, 23 Apr 2021 12:56:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 23 Apr 2021 20:55:50 +0100 Message-ID: To: Niklas Keller Cc: Sara Golemon , PHP internals Content-Type: multipart/alternative; boundary="0000000000006fe27405c0a92fda" Subject: Re: [PHP-DEV] Binary (un)safety of password_hash() used with PASSWORD_BCRYPT From: tekiela246@gmail.com (Kamil Tekiela) --0000000000006fe27405c0a92fda Content-Type: text/plain; charset="UTF-8" We can also consider switching the default to Argon2id. As Scott says the NUL byte truncation is not a bug in PHP, but a bug in the algorithm. I don't know the exact specification but maybe we should leave the current implementation as is? --0000000000006fe27405c0a92fda--