Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114107
MIME-Version: 1.0
References: <CAESVnVpCK87GL=+nCvXuT7YS6-QPhF3=8LZSZuAusGFXoT006A@mail.gmail.com>
 <CANUQDCjVfdggrF3wjBCsQ=b_85cq1RhnO_kkVfP3QGubmZhg+g@mail.gmail.com>
 <CAESVnVr+eOWbizGSAnDwu5+q1rQDe+zcd8r+jUDoRMht768WBA@mail.gmail.com> <CANUQDCgYhm=32HXa9Msi+UO335a2yk=MYtOL9a5DcpvU6Ct1GA@mail.gmail.com>
In-Reply-To: <CANUQDCgYhm=32HXa9Msi+UO335a2yk=MYtOL9a5DcpvU6Ct1GA@mail.gmail.com>
Date: Thu, 22 Apr 2021 17:21:46 -0500
Message-ID: <CAESVnVqefvhTujS117M8o7Bh=gq7wP2cUjV9quZ3fy9ksRN+qQ@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007ef3ab05c0971b0f"
Subject: Re: [PHP-DEV] Binary (un)safety of password_hash() used with PASSWORD_BCRYPT
From: pollita@php.net (Sara Golemon)

--0000000000007ef3ab05c0971b0f
Content-Type: text/plain; charset="UTF-8"

On Thu, Apr 22, 2021 at 3:27 PM Niklas Keller <me@kelunik.com> wrote:
>> Do you have a link to places where frameworks are doing this?  I built a
>> contrived example which I think summarizes the behavior you described
here:
>> https://3v4l.org/6tunp
>
> I have links to a library / blog post:
>
> https://github.com/paragonie/password_lock
>
https://paragonie.com/blog/2016/02/how-safely-store-password-in-2016#why-bcrypt
>
> We're probably better off returning false for verify then instead of
throwing? Hash could hash a random password instead if NUL bytes are
present.
>

So this library (which I'd need convincing is widely used) doesn't actually
have any null byte problems.
Yes, the digest produced by hash(...,true) could have null bytes,
but it's immediately piped into base64_encode() which papers directly over
that issue producing only ascii printable output.

-Sara

--0000000000007ef3ab05c0971b0f--