Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114040
MIME-Version: 1.0
References: <CAF+90c_PyPCd0ndtvZocJwD73_sxgxQYsOiAw8V5tSjTH3oR1A@mail.gmail.com>
 <1ffb0fbf-43f9-274a-37e0-8b650c02042b@gmail.com>
In-Reply-To: <1ffb0fbf-43f9-274a-37e0-8b650c02042b@gmail.com>
Date: Mon, 12 Apr 2021 17:52:32 +0200
Message-ID: <CAG9XoMTwMwBihDMRu8yn4pVTQkxw1YjH+TBFc4AYhwA8jU5Yfg@mail.gmail.com>
To: Dik Takken <dik.takken@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002384fb05bfc8814a"
Subject: Re: [PHP-DEV] Allow commit() without transaction?
From: benjamin.morel@gmail.com (Benjamin Morel)

--0000000000002384fb05bfc8814a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

>
>
> I think it is really nice that commit() throws for inactive
> transactions. Code paths that mess up your transactions will not go
> unnoticed that easily.
>

+1. I've always found this behaviour in MySQL very surprising and error
prone (BEGIN; BEGIN; COMMIT; COMMIT; =3D> no errors), and I'm actually very
happy to see this solved at PDO level.

IMO if someone relies on commit() not throwing if there is no active
transaction, they should be the one doing the extra check: if
($pdo->inTransaction()) $pdo->commit().

=E2=80=94 Benjamin

--0000000000002384fb05bfc8814a--