Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114037
MIME-Version: 1.0
References: <CAF+90c9crhPpSMcTx-ozGo0LGjNuBU43e8fiK_=PJMU6iTHNmw@mail.gmail.com>
 <28be190c-21ea-b796-cec7-b8db21d14eca@gmail.com> <CAF+90c8n_Ny5h8JyF6jKc0i4Rg_=msKEa1Eum6rQJmcV2cGQvw@mail.gmail.com>
In-Reply-To: <CAF+90c8n_Ny5h8JyF6jKc0i4Rg_=msKEa1Eum6rQJmcV2cGQvw@mail.gmail.com>
Date: Mon, 12 Apr 2021 15:15:02 +0200
Message-ID: <CAH5C8xWEA7ujHWp4DXUMKrepH8ef3efnT5zJ49RVSE1qqkvhGA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d0dad905bfc64d28"
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000d0dad905bfc64d28
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Nikita and Stanislav,

>  > get_class(), get_parent_class() and get_called_class() without argumen=
t
> >
> > I'm not sure why. I mean if we want to make them return the same as
> > self::class etc. - up to the point of actually compiling them as such -
> > no problem, but I don't see why they need to be deprecated. And I
> > vaguely remember seeing get_class() at least a bunch of times in old
> > code, when ::class didn't even exist. I don't see a good reason why tha=
t
> > code should be broken.
> >
>
> I agree with you on this one. From my perspective, there should be some
> technical motivation for deprecations, and this one seems to be more abou=
t
> coding style -- it removes an old way to write something, which has been
> subsumed by a different construct in the meantime. I think M=C3=A1t=C3=A9=
 suggested
> this one, maybe he can provide additional reasoning.
>

The technical motivation why I suggested this idea is because the optional
parameter of get_class() and get_parent_class() doesn't have a correct
default value
since https://wiki.php.net/rfc/get_class_disallow_null_parameter. So I
don't really mind
the coding style perspective, I'd only like to ensure that default value
handling is
right without reverting the relevant RFC. If you think it's too much of a
BC break for a
small gain, then I'm ok to remove this item from the list.

Regards:
M=C3=A1t=C3=A9

--000000000000d0dad905bfc64d28--