Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114029
Message-ID: <6b8007c0-758a-c2f3-66df-7daf40cea724@beccati.com>
Date: Mon, 12 Apr 2021 14:13:42 +0200
MIME-Version: 1.0
Content-Language: en-GB
To: Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAF+90c_PyPCd0ndtvZocJwD73_sxgxQYsOiAw8V5tSjTH3oR1A@mail.gmail.com>
In-Reply-To: <CAF+90c_PyPCd0ndtvZocJwD73_sxgxQYsOiAw8V5tSjTH3oR1A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Allow commit() without transaction?
From: php@beccati.com (Matteo Beccati)

Hi Nikita,

On 12/04/2021 14:07, Nikita Popov wrote:
> $pdo->beginTransaction()
> $pdo->exec('DROP TABLE foobar'); // Implicitly commits transaction
> $pdo->exec('DROP TABLE barfoo'); // Transaction not active anymore
> $pdo->commit(); // Throws because no transaction active
> 
> now throws an exception, because commit() is called without an active
> transaction. It's possible to use if ($pdo->inTransaction())
> $pdo->commit(); if you don't care about the lack of active transaction.
> 
> I believe this behavior is correct, but I could see an argument made in
> favor of always allowing commit() calls (but not rollBack() calls) even if
> there is no active transaction. That would change the meaning of commit()
> from "commit an active transaction" towards "commit if an active
> transaction exists".
> 
> Any opinions on that?

I agree. As a user I'd prefer to be alerted that the transaction was not 
actually active rather than relying on seemingly working code that 
doesn't do what's on the tin.

In fact I probably never knew about this particular MySQL quirk and most 
likely I had been fooled many times into thinking that the code above 
was a single transaction.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/