Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114026
MIME-Version: 1.0
References: <CAG9XoMQFF+Anutc92iGFX1bOw-w1TWvwNa-XZeKw1GrGGSbWGg@mail.gmail.com>
In-Reply-To: <CAG9XoMQFF+Anutc92iGFX1bOw-w1TWvwNa-XZeKw1GrGGSbWGg@mail.gmail.com>
Date: Mon, 12 Apr 2021 11:47:55 +0200
Message-ID: <CAF+90c9L9aY4F7ScGbfEPvNncZ29h0m9qSW9FXEnOW0VhF4aMA@mail.gmail.com>
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000690fca05bfc36900"
Subject: Re: [PHP-DEV] Required parameter after optional one
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000690fca05bfc36900
Content-Type: text/plain; charset="UTF-8"

On Fri, Apr 9, 2021 at 9:24 AM Benjamin Morel <benjamin.morel@gmail.com>
wrote:

> Hi internals,
>
> I'm wondering why PHP 8 started warning about required parameters declared
> after optional ones, when this version is the one that also introduced
> named parameters, which can take advantage of this:
>
> ```
> function test($a = 1, $b) {
>     echo $a, $b;
> }
>
> test(b: 2);
> ```
>
> > Deprecated: Required parameter $b follows optional parameter $a in
> /in/DmhYG on line 3
> > 12
>
> https://3v4l.org/DmhYG
>
> If I'm not mistaken, the introduction of this warning (January 2020
> <https://externals.io/message/108052>) predates the introduction of named
> parameters (May 2020 <https://wiki.php.net/rfc/named_params>), which could
> explain why it would have temporarily made sense to introduce this warning.
>
> Shouldn't it be removed now, that it makes IMO full sense with named
> parameters to have required and optional parameters at arbitrary positions?
>

I'd say it's the other way around, and named parameters are at fault here:
We should not be allowing that call. We should probably explicitly drop
such default values during compilation (which will change reflection output
though).

Nikita

--000000000000690fca05bfc36900--