Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:114023 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 16980 invoked from network); 11 Apr 2021 18:21:29 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 11 Apr 2021 18:21:29 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 3C2671804C6 for ; Sun, 11 Apr 2021 11:21:49 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 11 Apr 2021 11:21:48 -0700 (PDT) Received: by mail-ed1-f47.google.com with SMTP id w18so12439180edc.0 for ; Sun, 11 Apr 2021 11:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=PPig15J+oG7x0MM7HfG/laGB8K2PA/UCTS40gYAmd74=; b=QhShmWOS8wAH7WX+fRo7rNNTKOwfyMTBbhEcLpaRqifLbdtxpQzFHua911QSoZtZMb 9MIAesvGkScMTYdH0kHR7Kny0mK9/aApnuRwFQsLrNSXI4I71+5FGue4W0KSHYin0jxp ODbQBavE2TRDE+6QOFMiqMrRK6Jh7GoAvxn+L1GAc9VaBHGH8CYlkPxhjrgp+JFvIw5S /Q6qhpZlWf4Ee/u1Iwe8P/QGAIVntAyr9ijsRPJ2R54Q7LxL5SgNqtMRcqWc8v5zi0+e XhQIYirHhFugf8vQqJy/QyJvVa9aJUEs+gZT6bLKmoMbbfzrb01uu13v9xyB1nIegEa5 g0fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=PPig15J+oG7x0MM7HfG/laGB8K2PA/UCTS40gYAmd74=; b=RDfDdylrudGBiXSpgvPdNkYbSB662hVLkEQi6gzjlk3QY+gxxFR5qo45UmWP5mXho6 TyVfh7TteYRoIJa/sfyUZz3ZG5vsPmrqCiOiwLLPQ4vl5sF+VzrOBSVBP0bMRPplzIGw 8JgAh07MQkkQOFSff6IIpspfRpJIWeFEfA6lNHJR5PnEJuH561pevMAYRL2pHaTypnue bz6ngoscYaQvZmPrgNgvSvGczgMIUCzfmdceHVricAQEdRkjieOmNoZKo+HIXThRz9e5 /iBqsNV+F6Wf3UgyaE0pozkHnZOMCZAeGmdvAYCNxqCw3SW9hVncC0v/fQYdoHSM5HfU BK3w== X-Gm-Message-State: AOAM5307jYgBuGy0UDalkS9a3Hrh7ycH3Is9OzjT9t3NUl0YCrY+13Bk 9E0AsoVTk8RsORd9FTThX0r1VHQ+UDI= X-Google-Smtp-Source: ABdhPJy4yEXsxDOFcwiyEQVVG2QKvvrvwriWQJJoqNUGcSZHNVMvgRjZRBl+zAgBy7Dxsas3Z8k7/Q== X-Received: by 2002:a50:e607:: with SMTP id y7mr26631383edm.18.1618165305973; Sun, 11 Apr 2021 11:21:45 -0700 (PDT) Received: from [192.168.0.22] (cpc104104-brig22-2-0-cust548.3-3.cable.virginm.net. [82.10.58.37]) by smtp.googlemail.com with ESMTPSA id u24sm4385553ejn.5.2021.04.11.11.21.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Apr 2021 11:21:44 -0700 (PDT) To: PHP Internals References: <754310d2-f12e-84fc-cbc8-55f6e46e2ff8@gmail.com> Message-ID: Date: Sun, 11 Apr 2021 19:21:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [PHP-DEV] Function getdir() accidentally exists From: rowan.collins@gmail.com (Rowan Tommins) On 07/04/2021 00:15, Sara Golemon wrote: > With my 8.0 RM hat on, I say we do that.  Call this a bug that the > *undocumented* function existed in 8.0.0 through 8.0.3 and remove it.  > The window of code that will break will be vanishingly small, and if > it does impact anyone, the fix is to call dir() instead. Sorted. Since nobody objected, but nobody seemed to have got round to it yet, I've raised a PR to remove getdir() and rename the internal implementation to dir() once and for all: https://github.com/php/php-src/pull/6855 Regards, -- Rowan Tommins [IMSoP]