Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114022
MIME-Version: 1.0
References: <CAP-hcNSGz6WQaCaebLdDm26emTrzxBUpyYvO0MF6anVB8t+=mg@mail.gmail.com>
 <CAGBsUrexRQiCuFbecaGGv_uho9m+QeUfO9+uG4A5z2beyZ1Sog@mail.gmail.com>
 <CAP-hcNSUWtLfiHc_VcGCPC=uneA8BCE=qNLp6p-S8niP_kmaQA@mail.gmail.com> <CAGBsUrfhTFuH3Q2ckTwT=z1hZqNTF8eL6kOreSQp1Lb8fHBikg@mail.gmail.com>
In-Reply-To: <CAGBsUrfhTFuH3Q2ckTwT=z1hZqNTF8eL6kOreSQp1Lb8fHBikg@mail.gmail.com>
Date: Sun, 11 Apr 2021 10:48:59 -0700
Message-ID: <CAP-hcNS5f=Ow5jfvocwtP9dvT9vjxcD_2u_Rs0xTZX4fcbEOcg@mail.gmail.com>
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000aa359605bfb6034e"
Subject: Re: [PHP-DEV] Use MySQL syntax only for parsing MySQL statements in PDO
From: morozov@tut.by (Sergei Morozov)

--000000000000aa359605bfb6034e
Content-Type: text/plain; charset="UTF-8"

Kamil,

> You are attempting to fix a small issue in another driver while the MySQL
parser is already broken with similar bugs.

Yes, this is what the original idea was given the existing bugs on
bugs.php.net while I wasn't aware of all the other MySQL parser problems
that you pointed out.

> Which is kind of my point.

Point taken.

Matteo,

This is great to see this effort happening! As I understand, you also
implement an API for platform-specific parsers but via a much better
extensible API.

I'm curious if instead of keeping the MySQL syntax in the default parser
and creating one for PostgreSQL, it would make sense to create a MySQL
parser and remove the support for backslash escaping from the default one?

> Perhaps we could work together and come up with an RFC?

Thanks for the offer but I don't think I'll be able to prioritize this
effort over my other projects. Based on the conversation above, reworking
the parser the right way requires a lot of investment and frankly speaking
it's not the most critical problem in the world to solve (all these bugs
are edge cases).

Regards,
Sergei Morozov

--000000000000aa359605bfb6034e--