Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114021
MIME-Version: 1.0
References: <CAP-hcNSGz6WQaCaebLdDm26emTrzxBUpyYvO0MF6anVB8t+=mg@mail.gmail.com>
 <CAGBsUrexRQiCuFbecaGGv_uho9m+QeUfO9+uG4A5z2beyZ1Sog@mail.gmail.com> <CAP-hcNSUWtLfiHc_VcGCPC=uneA8BCE=qNLp6p-S8niP_kmaQA@mail.gmail.com>
In-Reply-To: <CAP-hcNSUWtLfiHc_VcGCPC=uneA8BCE=qNLp6p-S8niP_kmaQA@mail.gmail.com>
Date: Sun, 11 Apr 2021 16:28:57 +0100
Message-ID: <CAGBsUrfhTFuH3Q2ckTwT=z1hZqNTF8eL6kOreSQp1Lb8fHBikg@mail.gmail.com>
To: Sergei Morozov <morozov@tut.by>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e0ac4905bfb40e42"
Subject: Re: [PHP-DEV] Use MySQL syntax only for parsing MySQL statements in PDO
From: tekiela246@gmail.com (Kamil Tekiela)

--000000000000e0ac4905bfb40e42
Content-Type: text/plain; charset="UTF-8"

> This specific issue doesn't seem to be related to the emulation. As far
as I understand, PDO parses SQL as well in order to replace positional
placeholders and vise versa depending on the input and the target platform
capabilities.

True, PDO has a huge flaw because of its SQL parser. In non-emulation mode
PDO will attempt to only replace named parameters with ?. This leaves a
much smaller vector for bugs. How many people put : in their SQL? With a
context-aware parser, we could minimize this to close to zero.

> I tried running the example on the stock PHP 8.0.3, and regardless of the
emulation mode and NO_BACKSLASH_ESCAPES mode I saw the same error:

I don't think this is possible. I executed it with PHP 8.0.3 and it only
fails in emulation mode.

> With my patch, I don't expect to see any changes in parsing MySQL queries
so I don't understand how it's relevant. Am I missing something?

Which is kind of my point. You are attempting to fix a small issue in
another driver while the MySQL parser is already broken with similar bugs.
If we are going to have diverging parsers then they should be entirely
split up. Keeping a single parser will lead to more bugs. If we try to
patch like this then it will soon get out of hand.

--000000000000e0ac4905bfb40e42--