Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114020
Message-ID: <7b05f88a-ffe4-cb7a-676e-eeadbea36a86@beccati.com>
Date: Sun, 11 Apr 2021 11:53:49 +0200
MIME-Version: 1.0
Content-Language: en-GB
To: Sergei Morozov <morozov@tut.by>, PHP Internals <internals@lists.php.net>
References: <CAP-hcNSGz6WQaCaebLdDm26emTrzxBUpyYvO0MF6anVB8t+=mg@mail.gmail.com>
In-Reply-To: <CAP-hcNSGz6WQaCaebLdDm26emTrzxBUpyYvO0MF6anVB8t+=mg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Use MySQL syntax only for parsing MySQL statements in
 PDO
From: php@beccati.com (Matteo Beccati)

Hi Sergei,

in fact I have been working on a secret plan to allow each driver to 
optionally have their own parser. Due to very limited time I haven't 
finalised all the details, but the proof of concept looks promising:

https://github.com/php/php-src/pull/6852

Perhaps we could work together and come up with an RFC?


Cheers

On 10/04/2021 19:13, Sergei Morozov wrote:
> Hi Internals,
> 
> There are bugs #79276 <https://bugs.php.net/bug.php?id=79276> and #80340
> <https://bugs.php.net/bug.php?id=80340> where PDO parses valid PostgreSQL
> statements incorrectly because it uses MySQL grammar for all statements
> regardless of the underlying platform.
> 
> I submitted pull request #6410 <https://github.com/php/php-src/pull/6410> which
> enables extensions to opt-in to MySQL-specific syntax (since it's not
> standard). Currently only `pdo_mysql` uses it.
> 
> As Christoph Becker suggested, I'm bringing it here for discussion.
> 
> Technically, it may be a BC break since there may exist PDO-based
> extensions outside the PHP repository that rely on compatibility with the
> MySQL syntax.
> 
> Are there known extensions like this? Would this change be acceptable in
> one of the next minor releases?
> 
> Regards,
> Sergei Morozov
> 


-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/