Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11402 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97889 invoked by uid 1010); 20 Jul 2004 22:32:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 97824 invoked from network); 20 Jul 2004 22:32:08 -0000 Received: from unknown (HELO mail.zend.com) (80.74.107.235) by pb1.pair.com with SMTP; 20 Jul 2004 22:32:08 -0000 Received: (qmail 8056 invoked from network); 20 Jul 2004 22:32:06 -0000 Received: from localhost (HELO AndiNotebook.zend.com) (127.0.0.1) by localhost with SMTP; 20 Jul 2004 22:32:06 -0000 Message-ID: <5.1.0.14.2.20040720153149.02af71c0@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Tue, 20 Jul 2004 15:31:56 -0700 To: Michael Sisolak ,internals@lists.php.net In-Reply-To: <20040720215525.63006.qmail@web13423.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929) From: andi@zend.com (Andi Gutmans) References: <20040720215525.63006.qmail@web13423.mail.yahoo.com> You forgot to attach the patch... At 02:55 PM 7/20/2004 -0700, Michael Sisolak wrote: >I believe that a bug was introduced with version 1.3 of php5isapi.c. >The sapi_isapi_read_cookies() function used to return NULL when there >were no cookies, but was changed to return "" instead. That's fine, >but then HttpExtensionProc() attempts to free the non-ealloc'ed empty >string and dies with an Access Violation. I believe this is the issue >people are seeing in bug #28929. > >I've attached a patch for the PHP_5_0 branch that has >sapi_isapi_read_cookes() return an empty_string constant, and uses >STR_FREE to call efree() to protect the case of the empty_string value. > For HEAD this patch would be easier becuase of the recent removal of >empty_string - just return STR_EMPTY_ALLOC() and keep the efree() as >is. > >Michael Sisolak >msisolak@yahoo.com > > > > >__________________________________ >Do you Yahoo!? >New and Improved Yahoo! Mail - Send 10MB messages! >http://promotions.yahoo.com/new_mail >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php