Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113983
MIME-Version: 1.0
References: <754310d2-f12e-84fc-cbc8-55f6e46e2ff8@gmail.com>
In-Reply-To: <754310d2-f12e-84fc-cbc8-55f6e46e2ff8@gmail.com>
Date: Tue, 6 Apr 2021 18:15:55 -0500
Message-ID: <CAESVnVqi+zRCMBF+taG1zR573xOww+z0nQ7WuZ3KcansP65MQA@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a8e7e205bf55ff37"
Subject: Re: [PHP-DEV] Function getdir() accidentally exists
From: pollita@php.net (Sara Golemon)

--000000000000a8e7e205bf55ff37
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 6, 2021 at 5:04 PM Rowan Tommins <rowan.collins@gmail.com>
wrote:
> Because the PHP function didn't match the C function name,
> this got translated to a function *alias* in PHP 4 [1]:
>
Curious, since PHP_NAMED_FE *did* exist in this revision that Ze'ev didn't
choose to use that macro.  Mid 1999 though, so I imagine the development
pace going into ZE1 was pretty heavy. Whoopsie!

> The obvious question is: should this be considered a bug, and undone,
> and if so, how?
>
> The answer is probably to do what should have been done 20 years ago,
> and rename the internal definition to match the function name exposed to
> the user.
>

With my 8.0 RM hat on, I say we do that.  Call this a bug that the
*undocumented* function existed in 8.0.0 through 8.0.3 and remove it.  The
window of code that will break will be vanishingly small, and if it does
impact anyone, the fix is to call dir() instead. Sorted.

 As to whether or not we deprecate dir()/Directory in 8.x... eh... I'm
swiss on that.  It's been there for ages and isn't hurting anyone, is it?

-Sara

--000000000000a8e7e205bf55ff37--