Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113910
MIME-Version: 1.0
References: <CABTDVhD+gK9rqSceDa0Ct7OcsgT5E6+Lb_nX_gCfzq-oZnNpxw@mail.gmail.com>
 <CAC5V6ghwboJGHbj-3MQXePVJNr1Rt6MUjvT_J7gtUA0BpHMqSg@mail.gmail.com>
In-Reply-To: <CAC5V6ghwboJGHbj-3MQXePVJNr1Rt6MUjvT_J7gtUA0BpHMqSg@mail.gmail.com>
Date: Thu, 1 Apr 2021 23:38:01 +0900
Message-ID: <CABTDVhCo4AiEzOQbnhW0kQ6Kct_R7kV2w2fCbrmteB+XSd8P=g@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004bc27a05beea2eb7"
Subject: Re: [PHP-DEV] [VOTE] Object scoped RNG implementation
From: zeriyoshi@gmail.com (Go Kudo)

--0000000000004bc27a05beea2eb7
Content-Type: text/plain; charset="UTF-8"

Hi Xavier

> If I understand correctly, this would
>  - provide us with performant object-encapsulated (isolated from global
state) equivalents of the existing `mt_srand()`/`mt_rand()` and
`random_int()` functions as well as a new "XorShift128+"; along with some
global functions for usability, notably `rng_bytes()` and `rng_int()`
respectively similar to `random_bytes()` and `random_int()` but with an
additional (first) RNG argument
>  - enable us to use them (the objects), as well as other (extension or
userland) implementations of the `RNG\RNGInterface`, for the existing
`array_rand()`, `shuffle()` and `str_shuffle()` functions (instead of the
default internal MT implementation)

Yes, that's right.

> I can't vote (yes), but I just suggest you complete the stubs in the RFC
with what can been seen at <
https://github.com/php/php-src/pull/6568/files?file-filters%5B%5D=.php#diff-d469bf38690924187e7b9db4a8ab199a99394b404bb12325a789141c56edb12f>
and below, showing that the class `OS` has the minimal interface while
classes `MT19937` and `XorShift128Plus` have a public
`__construct(int $seed)` and implement the magic
`__serialize()`/`__unserialize()`.

I've added it to the RFC.
Thank you!

--0000000000004bc27a05beea2eb7--